Conversation
davidgiven
reviewed
Sep 22, 2026
|
|
||
| # if pos or len are not block-aligned, do multiple reads and use FCB buffer to copy | ||
|
|
||
| sub stdio_pread(fcb: [FCB], dma: [uint8], len: FCBIndexType, pos: uint32): (amount: StdioType) is |
Owner
There was a problem hiding this comment.
I think this will need to flush any unwritten changes still in the FCB buffer.
For CP/M it may be worth not implementing pread/pwrite directly, but instead implementing it on top of the existing seek/read/write routines. CP/M is so slow that the extra overhead of copying the data a byte-at-a-time in and out of the buffer is probably not going to do too much to performance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Good thing we're not limited by single 64 KB address space and block-aligned I/O any more, eh?