QA dataset generation and rise experiment#175
Open
shackmann wants to merge 13 commits into
Open
Conversation
shackmann
requested review from
alex-dr and
mhauskn-dr
and removed request for
alex-dr and
mhauskn-dr
alex-dr
reviewed
Jul 28, 2025
| supporting_facts=[], | ||
| difficulty="default", | ||
| qtype="default", | ||
| gold_evidence=[], |
Collaborator
There was a problem hiding this comment.
The dataset generation script seems to populate this field - we should include it here.
alex-dr
reviewed
Jul 28, 2025
alex-dr
left a comment
alex-dr
left a comment
Collaborator
There was a problem hiding this comment.
Mike had some logic for reviewing and filtering generated QA pairs after generation. From what I've seen, we can end up with partially generated answers and stuff, so it'd be good if we can look up what he was doing and incorporate it into the notebook.
alex-dr
reviewed
Sep 11, 2025
alex-dr
left a comment
alex-dr
left a comment
Collaborator
There was a problem hiding this comment.
Looks okay, but we need to rebase this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.