Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .claude/skills/simplifions-verify/features/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ Index for `simplifions-verify`. One file per user-facing feature; each holds the
- [guides-mis-en-avant.md](guides-mis-en-avant.md) — the home section of three guides, the commune guide card after the third result of the catalogue filtered on communes, and an article's og:image and schema.org `Article` dates.
- [plan-du-site.md](plan-du-site.md) — the footer's Plan du site lists every visible cas d'usage, solution and article under its entry, alphabetical; a truncated fiche description keeps its apostrophes in meta and og tags.
- [pied-de-page.md](pied-de-page.md) — on every page and in the admin, the footer's five blocks of links open the filtered catalogue, the guides and the comparisons; the presentation links to the home section on what the site brings.
- [clavier-lecteur-ecran.md](clavier-lecteur-ecran.md) — first Tab on « Contenu », catalogue filters applied by a button, changing numbers announced in status regions (solution counter, endpoints, Sirene demo), icons shown but not read aloud.
- [clavier-lecteur-ecran.md](clavier-lecteur-ecran.md) — first Tab on « Contenu », catalogue filter tags walked with Tab and applied with Enter, changing numbers announced in status regions (solution counter, endpoints, Sirene demo), icons shown but not read aloud.
- [demo-sirene.md](demo-sirene.md) — the Sirene demo of the article « Qu'est-ce qu'une API ? »: the waiting icon turns, and stays still when the device asks to reduce animations.
- [survol-souris.md](survol-souris.md) — the cas d'usage card, the catalogue « Type » choice and the floating « Proposer une modification » button change colour under a mouse only; on a touch screen they keep their colour.
- [bouton-proposer-modification.md](bouton-proposer-modification.md) — the floating « Proposer une modification » button never hides the element reached with Tab, and is 40 px tall on a phone too.
Expand Down
4 changes: 2 additions & 2 deletions .claude/skills/simplifions-verify/features/admin-dates.md
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
# Dates de création et de modification tenues seules

The administration dates a démarche, a solution or a recommandation by itself: `cree_le` and `modifie_le` at creation, `modifie_le` at every save. The forms no longer offer the two fields. The Grist import and the data.gouv refresh keep the Grist dates (they do not go through the admin controllers).
The administration dates a démarche or a solution by itself: `cree_le` and `modifie_le` at creation, `modifie_le` at every save; a recommandation has only `modifie_le`. The forms no longer offer the two fields. The Grist import and the data.gouv refresh keep the Grist dates (they do not go through the admin controllers).

## Sub-features

- `dates-creation` no date field in the form; creating a démarche dates `cree_le` and `modifie_le`.
- `dates-modification` each save moves `modifie_le` and keeps `cree_le`.
- `dates-solutions-recommandations` the same on solutions and recommandations (spec only).
- `dates-solutions-recommandations` the same on solutions; a recommandation only gets `modifie_le` (spec only).
- `dates-import` the Grist import keeps the Grist dates (spec only).

## How to get to it (user POV)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ Preconditions: logged in; the drive works on a solution it creates (`Vérif veri

- **Privée.** Open the solution from the left list: badge under the H1.
- **Image.** Preview alt = légende, hint lists the formats.
- **Catégorie.** Select `API` → empty Slug and Description courte hidden and disabled, the filled légende and the image group (`Retirer l’image`) stay visible and enabled; `Annuler` asks « Quitter sans enregistrer » (#81 still sees the change); back to `Brique technique` → all visible.
- **Catégorie.** Select `API` → empty Titre SEO and Description courte hidden and disabled; the Slug (tiré du nom at creation), the filled légende and the image group (`Retirer l’image`) stay visible and enabled; `Annuler` asks « Quitter sans enregistrer » (#81 still sees the change); back to `Brique technique` → all visible.
- **One save.** Empty the légende, tick `Retirer l’image`, select `API` (the emptied légende stays visible: its rendered value was filled), `Enregistrer` → database: catégorie api, no légende, no image.
- **Proof.** `tmp/verify/admin-formulaire-solution/`, including `etroit-320`.

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,8 @@ def image(page, solution)

def api_choisie(page)
page.select 'API', from: 'Catégorie de solution'
etat = etat_des_champs(page, %w[solution_slug solution_description_courte solution_legende_image solution_retirer_image])
attendu = { 'solution_slug' => [true, true], 'solution_description_courte' => [true, true],
etat = etat_des_champs(page, %w[solution_slug solution_titre_seo solution_description_courte solution_legende_image solution_retirer_image])
attendu = { 'solution_slug' => [false, false], 'solution_titre_seo' => [true, true], 'solution_description_courte' => [true, true],
'solution_legende_image' => [false, false], 'solution_retirer_image' => [false, false] }
raise "API : #{etat}" unless etat == attendu

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ The drive creates `Vérif verify-map <browser>` as `Import Grist`, renames it fr
- **Mobile.** 375 px: no horizontal scroll.
- **Back.** `Retour à la fiche` → the edit page.
- **Draft.** The drive publishes the démarche, renames it in the en-tête modal, `Enregistrer`, `Historique de la démarche`: first `h2` `Modification en brouillon par verif@simplifions.local le …`, first row `Nom | <published> | <draft>`.
- **Publication.** `Publier`: first `h2` `Publication du brouillon par …`, same row.
- **Publication.** `Publier ce changement` (box `À la publication, …`): first `h2` `Publication du brouillon par …`, same row.
- **Abandon.** Rename back in the en-tête modal, `Enregistrer`, `Abandonner le brouillon` (confirm): first `h2` `Abandon du brouillon par …`, same row, then `Retour à la fiche`; base events end with `brouillon, publication, brouillon, abandon`.
- **Proof.** Screenshots and `read-back.txt` in `tmp/verify/admin-historique/`.

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ A list of 10 linked rows or fewer in an admin form shows every box on load, chec

- `courte-liste` 10 choices or fewer: every box shown, no `Filtrer les <liste>` field, no live line; decided at page load from the number of choices.
- `liste-filtrable` field `Filtrer les <legend in lowercase>`, hint `Sans filtre, seuls les éléments cochés sont affichés ; cliquer dans le champ ou y appuyer sur flèche bas affiche tous les choix.`; Tab into the field opens nothing; once opened, every box stays shown until the cross or until focus leaves the fieldset with an empty filter (a click on blank page, on a label or on blank space inside the list keeps it open, also inside a tab of a fiche); every word must match, accents and case ignored; a polite live line `2 cochés sur 474` (empty filter) or `1 résultat sur 474, 3 cochés`. The boxes stay native: Tab reaches the shown ones, Space checks.
- The filter field has no `name`: typing in it does not count as a change (no `Quitter sans enregistrer ?`) and Enter in it does not submit the form.
- The filter field has no `name`: typing in it does not count as a change (no `Quitter sans enregistrer les modifications ?`) and Enter in it does not submit the form.
- `vocabulaires-groupes` nested fieldsets inside `Vocabulaires` (on a démarche, split between the en-tête and `Vocabulaires` modals), démarche and solution forms, a `?` beside every vocabulaire (see `admin-pages-liees.md`).

## How to get to it (user POV)
Expand Down
2 changes: 1 addition & 1 deletion .claude/skills/simplifions-verify/features/admin-listes.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ Démarches and solutions are not tables: the list stays on the left in a `Liste

## Sub-features

- `admin-recherche` field `Rechercher` (`Rechercher une démarche` on the two left lists) + button `Rechercher` (GET `?q=`), accents and case ignored, every word must match. A search with no result shows « Aucune démarche ne contient « x ». » (« Aucun vocabulaire… », noun and gender of the list) instead of the count and the rows, then a link `Effacer la recherche` back to the full list; on démarches and solutions it sits in the left column. Démarches and solutions reuse the public catalogue search (name, short description, keywords for démarches); recommandations and intégrations match the names of the démarche and solutions they link; the other tables match the name.
- `admin-recherche` field `Rechercher` (`Rechercher une démarche` / `Rechercher une solution` on the two left lists) + button `Rechercher` (GET `?q=`), accents and case ignored, every word must match. A search with no result shows « Aucune démarche ne contient « x ». » (« Aucun vocabulaire… », noun and gender of the list) instead of the count and the rows, then a link `Effacer la recherche` back to the full list; on démarches and solutions it sits in the left column. Démarches and solutions reuse the public catalogue search (name, short description, keywords for démarches); recommandations and intégrations match the names of the démarche and solutions they link; the other tables match the name.
- `admin-pagination` 50 rows, `Page 2` link keeps `q` (not on démarches and solutions: one scrolling list, every row).
- `admin-colonnes` headers `Id`, `Nom` (or `Ligne`), `Visible`, `Modifié le` (recommandations). Organisations: `Nom court`, `Nom long`. Intégrations: the form labels `Solution` (the link), `API ou jeu de données`, `Type d’intégration`, `Statut de l’intégration`.
- `admin-liste-et-fiche` démarches and solutions: `[role=status]` count `N démarches`, select `État` (`Toutes`, `Publiées`, `Masquées`, `En brouillon`) applied by `Filtrer` (`?etat=`), one link per row (name, with the icon `aria-hidden` for démarches; badges `Publiée` / `Masquée` and `Brouillon`), `Ajouter une démarche`. A row opens `/admin/<table>/<id>/edit?etat=…&q=…`: the list keeps its search and filter, the open row is `aria-current="page"`.
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Relire les textes longs et rejoindre les pages liées

On an admin form, each text area is as tall as its content (rows computed server-side, no JS) and the fields rendered as Markdown on the site say `Markdown accepté`. A visible solution with a slug offers `Voir la page publique` in the `État et actions` column; a visible démarche shows its page address as a link in the `État de la démarche` bar, `Voir la page publique de <nom> - nouvelle fenêtre` in its `title`; both open a new tab. Each checked box of a filterable list from the catalogue, the recommandation's solution and the intégration's two solutions offer `Voir la fiche`, named `Voir la fiche <libellé>`, outside the checkbox label. Every vocabulaire and every fournisseur de services (checked or not) offers instead a `?` icon (`fr-icon-question-line`) beside its label, its text `Fiche de <nom> (nouvel onglet)` read by screen readers only, opening its read page in a new tab; both lists sit on three columns from 992 px (two from 576 px, one below).
On an admin form, each text area is as tall as its content (rows computed server-side, no JS) and the fields rendered as Markdown on the site say `Markdown accepté`. A visible solution with a slug offers `Voir la page publique` in the `État et actions` column; a visible démarche shows its page address as a link above its H1, `Voir la page publique de <nom> - nouvelle fenêtre` in its `title`; both open a new tab. Each checked box of a filterable list from the catalogue, the recommandation's solution and the intégration's two solutions offer `Voir la fiche`, named `Voir la fiche <libellé>`, outside the checkbox label. Every vocabulaire and every fournisseur de services (checked or not) offers instead a `?` icon (`fr-icon-question-line`) beside its label, its text `Fiche de <nom> (nouvel onglet)` read by screen readers only, opening its read page in a new tab; both lists sit on three columns from 992 px (two from 576 px, one below).

## Sub-features

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ Creates its own published démarche and solution `Vérif verify-map <browser>`,
- **Démarche.** No `Prévisualiser` before the draft; `Modifier l’en-tête`, `Nom` `<nom> brouillon`, `Enregistrer`, `Prévisualiser` in a new window: H1 the draft name, the notice; at 640 px wide (200 % zoom) no horizontal scroll.
- **Public page unchanged.** `/demarches/<slug>` H1 the published name, no notice; base `nom` unchanged.
- **Solution image.** Attach `app/assets/images/articles/api-franceconnectees-donnees-personnelles.png`, `Enregistrer`, `Prévisualiser`: the image shows, base image still not attached.
- **Integrating solution.** Intégration `consomme` `✅ en production` of the portail on the API, not yet linked to the démarche; `Choisir les intégrations` in the fiche (`/admin/demarches/:id/edit`), check it, `Enregistrer` (`brouillon enregistré, non publié.`), `Prévisualiser`: no error, the portail's name in the bouquet's `.reco-card` and in `#solutions-integratrices`; base `integration_ids` still empty; `/demarches/<slug>` shows it nowhere.
- **Integrating solution.** Intégration `consomme` `✅ en production` of the portail on the API, not yet linked to the démarche; `Ajouter une intégration à <bouquet>` on the bouquet's card in the fiche (`/admin/demarches/:id/edit`; the bouquet provides the API), check it, `Enregistrer` (`brouillon enregistré, non publié.`), `Prévisualiser`: no error, the portail's name in the bouquet's `.reco-card` and in `#solutions-integratrices`; base `integration_ids` still empty; `/demarches/<slug>` shows it nowhere.
- **Proof.** `tmp/verify/admin-previsualisation/`.

## Gotchas
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ def recommander(demarche, fixture)
def integration_cochee_en_brouillon(page, demarche, fixture)
recommander(demarche, fixture)
page.visit("/admin/demarches/#{demarche.id}/edit")
dialog = Verify.fenetre(page, 'Choisir les intégrations')
dialog = Verify.fenetre(page, "Ajouter une intégration à #{fixture[:bouquet].libelle_admin}")
dialog.find("label[for=demarche_integration_ids_#{fixture[:integration].id}]").click
dialog.click_button 'Enregistrer'
page.assert_text "« #{demarche.nom} » : brouillon enregistré, non publié."
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,4 +29,3 @@ Preconditions: logged in; mutating then undone. Démarche: the visible one with
## Gotchas

- Read-backs after a mutation go through `ActiveRecord::Base.uncached` (runner query cache).
- A run that fails midway leaves a recommandation with `ordre` 99 on that démarche: remove it before re-running, or the next run picks another solution.
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ Admins add, edit and delete rows of every catalogue table from plain DSFR forms;

## How to get to it (user POV)

- Dashboard `/admin` → link `Vocabulaires` (also Démarches, Solutions, Recommandations, Intégrations, Organisations, Fournisseurs de services).
- Dashboard `/admin` → link `Vocabulaires` (also Démarches, Solutions, Organisations, Fournisseurs de services); or the header menu `Référentiels`.
- URL `/admin/vocabulaires`, `/admin/vocabulaires/new`.
- Admin only.

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ Visitors browse the list of cas d'usages (démarches), narrow it by full-text se

- `catalogue-liste` shows the visible démarches, 20 per page, with a result count.
- `catalogue-recherche` filters by the `Rechercher` text field.
- `catalogue-facettes` filters by acteur, usager, catégorie de solution, type de simplification: each value is a DSFR selectable tag (a submit button, `aria-pressed`) showing its count, applied on click, disabled when it leads to no result unless chosen; several values of one facet add up (« ou »), facets combine (« et »). The focus then lands on the result count « N résultats sur M ». Acteurs show Communes et groupements, Départements, Régions, État, the 5 others in a native `details` « Afficher les 5 autres » (open when one of them is chosen, works without JavaScript; so does « Plus de filtres »). The tri keeps its select, applied by `Trier`, a button shown only while the chosen tri differs from the applied one.
- `catalogue-facettes` filters by acteur, usager, catégorie de solution, type de simplification: each value is a DSFR selectable tag (a submit button, `aria-pressed`) showing its count, applied on click, disabled when it leads to no result unless chosen; several values of one facet add up (« ou »), facets combine (« et »). The focus then lands on the result count « N résultats sur M » (« sur M » only while a filter leaves some out). Acteurs show Communes et groupements, Départements, Régions, État, the 5 others in a native `details` « Afficher les 5 autres » (open when one of them is chosen, works without JavaScript; so does « Plus de filtres »). The tri keeps its select, applied by `Trier`, a button shown only while the chosen tri differs from the applied one.
- `catalogue-type` switches between `Cas d'usages` and `Solutions` keeping the filters.
- `catalogue-titre-filtres` the H2 « Filtrer les cas d'usages » / « Filtrer les solutions » is read by screen readers only (`fr-sr-only`): the search bar follows the H1 on screen.

Expand Down Expand Up @@ -47,4 +47,4 @@ Preconditions:
- Read the count only after `assert_current_path(/q=march/, url: false)`: Chrome returns the old page otherwise.
- Facet values are slugs (`entreprises`), labels are capitalised (`Entreprises`).
- The footer repeats some facet labels as links (`Départements`): click the tag button (its text ends with its count).
- A tag sends the current values of its facet (hidden field) then its own: the URL can hold the facet twice, the last one counts.
- A tag sends the current values of its facet (hidden field) then its own. With JavaScript the form keeps the last value of each parameter and drops the empty ones; without it the URL can hold the facet twice, and the last one counts.
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ The first Tab of any page lands on a « Contenu » skip link that jumps to the m
## How to get to it (user POV)

- Any page, Tab from the address bar; admin pages too (same layout).
- `/demarches` or `/solutions`, left column, button under the last filter.
- `/demarches` or `/solutions`, left column, the filter tags.
- `/solutions/<slug>` of a solution integrated by several solutions, filters above the tabs.
- `/demarches/<slug>`, a recommendation with several endpoints, field `Filtrer les endpoints`.
- `/articles/qu-est-ce-qu-une-api`, field `Numéro de SIRET d'un établissement :`.
Expand All @@ -34,7 +34,7 @@ Preconditions: catalogue imported; a visible solution with several integrating s
- **Endpoints.** Unfold the recommandation, `set('zzzz')` in its endpoints field: its `[role=status]` (hidden, read with `visible: :all`) goes from empty to `0 endpoint`.
- **Sirene.** SIRET `123` then `Interroger l'API`: the status holds « …14 chiffres. »; replace `window.fetch` with a stub answering `nom_complet: 'Vérif Sirene'`, SIRET `35600000000048`: the status holds `Résultat : Vérif Sirene`.
- **Emoji muets.** On the démarche page: the tab title has no icon; the H1, the breadcrumb's current item and « Proposer une modification du contenu » read, without their `aria-hidden` part, the name or the heading alone, and that part holds the icon or ✒️; the « Pour vraiment simplifier » box shows 💡 only inside `aria-hidden`. The catalogue card link reads the same.
- **Proof.** `tmp/verify/clavier-lecteur-ecran/` screenshots per step and `read-back.txt`: focus text, hash, `dans_main=true`, value chosen with `meme_page=true`, URL after the button, counter before → after, both announcements, the read and seen texts of the icons.
- **Proof.** `tmp/verify/clavier-lecteur-ecran/` screenshots per step and `read-back.txt`: focus text, hash, `dans_main=true`, the tag reached with `meme_page=true`, URL after Enter on it with the focus on the result count, counter before → after, both announcements, the read and seen texts of the icons.

## Gotchas

Expand Down
Loading
Loading