-
Notifications
You must be signed in to change notification settings - Fork 132
Code changes in Bls_Cpi_category to fetch montly file of year 2025 #1887
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Code changes in Bls_Cpi_category to fetch montly file of year 2025 #1887
Conversation
Summary of ChangesHello @niveditasing, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the data ingestion process for BLS CPI category data by introducing a more resilient year-rollover mechanism. It dynamically determines the "effective" current year for data retrieval based on the availability of January files, ensuring continuous data collection even when the new year's data is not yet fully published. Additionally, it refines the monthly file download strategy and adds a robust URL existence check. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the download script for BLS CPI data to handle the year-end rollover more gracefully by introducing an effective_current_year. The changes also simplify the download logic for the current year's files. My review found a couple of issues with the new logic. There's a bug in how the effective month is calculated, for which I've provided a fix. Additionally, there's a redundant block of code that attempts to download files that were already downloaded, which should be removed to improve efficiency and clarity.
No description provided.