feat: add business demography by size class NUTS3 (BD_SIZE_R3) (#37)#73
Merged
Conversation
- 5 dims: freq, indic_sb, sizeclas, nace_r2, geo - aggiunta update_sizeclas() a update_codelists.py + codelists/sizeclas.csv (32 voci, API ESTAT/SIZECLAS) - clean.sql: LEFT JOIN su sizeclas.csv, espone sizeclas_label_en - mart.sql: Italy NUTS3, tutte le dimensioni label, ORDER BY year/geo/indic_sb/sizeclas/nace_r2 - 128,498 righe mart Italy NUTS3
Member
Author
|
Review/fix pass fatto dopo merge di Ho sistemato tre punti:
Verifica locale fatta su
Ora aspetterei solo i check GitHub della PR prima di merge/review finale. |
Gabrymi93
approved these changes
Jul 1, 2026
Gabrymi93
left a comment
Member
There was a problem hiding this comment.
Matteo ha già fixato freq e risolto i conflitti autonomamente. PR solida:
sizeclascodelist via SDMX API ✅- 5 dimensioni, tutti i JOIN ✅
freqnel mart ✅- 120.955 righe mart, 0 null label ✅
Verdetto: merge 🎉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type
Problem
Issue #37 — BD_SIZE_R3 (Business demography by size class and NUTS 3 region) era in lista planned ma non implementato.
Solution
datasets/eurostat-business-demography-nuts3/condataset.yml,sql/clean.sql,sql/mart.sqlfreq,indic_sb,sizeclas,nace_r2,geoupdate_sizeclas()inscripts/update_codelists.pye generatocodelists/sizeclas.csv(32 codici via APIESTAT/SIZECLAS)clean.sql: LEFT JOIN susizeclas.csv→ colonnasizeclas_label_en; tutte le altre dims già coperte da codelist esistentimart.sql: Italy NUTS3, tutte le label, ORDER BY su tutte le dimensioni rilevanti0,1-9,GE10,TOTAL— tutti nel codelistdocs/dataset-registry.md: riga Published +BD_SIZE_R3in PlannedTest plan
pytest tests/ -vpasses (20/20)ruff check connectors/ tests/ scripts/passestoolkit run full --config datasets/eurostat-business-demography-nuts3/dataset.yml --years 2020passes (toolkit non installabile localmente su Python 3.14 — da verificare in CI)Downstream impact
Closes
Closes #37
Checklist
ruff check connectors/ tests/passesdocs/dataset-registry.mdupdated if adding a datasetdocs/contributing.mdtemplate still accurate