feat: add fertility indicators by NUTS3 (DEMO_R_FIND3) (#67)#71
Merged
Conversation
- 4 dims: freq, indic_de, unit, geo - indic_de: TOTFERRT (NR), AGEMOTH/MEDAGEMOTH (YR) — mart preserva entrambe le unità - codelist indic_de.csv esistente riusata - 3,979 righe mart Italy NUTS3
f2422f5 to
4435c59
Compare
Member
Author
|
Review tecnica ok da parte mia. Ho fatto un pass aggiuntivo prima di chiudere:
Confermo la scelta importante sul mart: niente filtro Verifiche fatte:
Nota pratica: GitHub non mi permette approval formale perche la PR risulta aperta da |
Gabrymi93
approved these changes
Jul 1, 2026
Gabrymi93
left a comment
Member
There was a problem hiding this comment.
Findings
Nessun finding critico. La PR è solida:
- Segue le convenzioni del repo (dataset.yml, clean.sql con LEFT JOIN, mart filtrato)
freqefreq_label_engià presenti nel mart — buona memoria dalle PR precedenti- Rimozione filtro
unit = 'NR'corretta (tagliava YR) indic_decodelist già esistente, zero nuovi codelist necessari- 76.392 clean rows, mart Italia NUTS3 verificato
Verdict: merge
Complimenti per l'attenzione ai dettagli! 🎉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type
Problem
Issue #67 — DEMO_R_FIND3 (Fertility indicators by NUTS 3 region) era in lista planned ma non implementato.
Solution
datasets/eurostat-fertility-nuts3/condataset.yml,sql/clean.sql,sql/mart.sqlfreq,indic_de,unit,geo(come descritto nell'issue)TOTFERRT(Total Fertility Rate, unit=NR),AGEMOTHeMEDAGEMOTH(età media/mediana al parto, unit=YR)unit = 'NR'generato automaticamente è stato rimosso perché taglierebbe le misure in annifreqefreq_label_en, coerente con gli altri dataset pubblicatiindic_de.csvgià esistente — join funziona su tutte e 3 le chiavidocs/dataset-registry.md: riga Published con 76.392 clean rows +DEMO_R_FIND3in PlannedTest plan
test (3.12)validate-configpython -m pytest tests/ -q→ 20 passedruff check connectors/ tests/ scripts/→ okDEMO_R_FIND3→ 76.392 clean rowsNReYR,yearINTEGER,valueDOUBLE, 0 null labels sufreq,indic_de,unit,geoDownstream impact
Closes
Closes #67
Checklist
ruff check connectors/ tests/passesdocs/dataset-registry.mdupdated if adding a datasetdocs/contributing.mdtemplate still accurate