-
Notifications
You must be signed in to change notification settings - Fork 138
feat(flags): folder organization support (schema + api + dashboard) #304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(flags): folder organization support (schema + api + dashboard) #304
Conversation
|
Someone is attempting to deploy a commit to the Databuddy OSS Team on Vercel. A member of the Team first needs to authorize it. |
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile OverviewGreptile SummaryImplements folder organization for feature flags with a clean, minimal approach that maintains backward compatibility. Key Changes:
Implementation Quality:
Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant User
participant Dashboard
participant FlagSheet
participant API
participant DB
User->>Dashboard: Select folder filter
Dashboard->>Dashboard: Filter flags by folder
Dashboard->>Dashboard: Group flags by folder
Dashboard-->>User: Display filtered/grouped flags
User->>Dashboard: Click "Create Flag"
Dashboard->>FlagSheet: Open flag creation form
User->>FlagSheet: Enter folder name (optional)
FlagSheet->>FlagSheet: Validate & trim folder input
User->>FlagSheet: Submit flag
FlagSheet->>API: POST /flags/create {folder, ...}
API->>API: Normalize folder (trim || null)
API->>DB: INSERT flag with folder
DB->>DB: Index on (website_id, folder)
DB-->>API: Flag created
API->>API: Invalidate cache for folder
API-->>FlagSheet: Success
FlagSheet-->>Dashboard: Close & refresh
Dashboard->>API: GET /flags/list {websiteId, folder?}
API->>DB: SELECT with folder filter
DB-->>API: Filtered flags
API-->>Dashboard: Flags list
Dashboard-->>User: Display updated flags
Last reviewed commit: 48f2263 |
Summary
Implements #271 with a minimal, shippable scope focused on folder organization (without changing flag evaluation logic).
What’s included
folderfield for flags in DB schema + migration (backward compatible)folderfolderfolderExplicitly unchanged
Acceptance checklist
Verification notes
bunavailable for project scripts (bun run lintfailed due to missing bun).