fix(analyzer): register three predefined recognizers missing from default_recognizers.yaml - #2218
Open
juno-junho wants to merge 1 commit into
Open
Conversation
juno-junho
force-pushed
the
fix/kr-passport-yaml-entry
branch
2 times, most recently
from
August 5, 2026 01:08
1e22643 to
354f8ce
Compare
…in default_recognizers.yaml
juno-junho
force-pushed
the
fix/kr-passport-yaml-entry
branch
from
August 5, 2026 05:05
354f8ce to
7221d7e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Description
Register the three pattern-based predefined recognizers that are exported in code but missing from
default_recognizers.yaml:AbaRoutingRecognizer,FiPersonalIdentityCodeRecognizerandSgUenRecognizer. Each entry shipsenabled: falsewith the matchingcountry_code, so default behavior is unchanged while no-code YAML users can discover and enable them. A test flips the three entries on and asserts they instantiate (all three constructors already accept the loader'snamekwarg, so these entries are enable-safe on their own).Scope note: this PR originally also fixed the
name-kwarg TypeError on four other recognizers and registeredKrPassportRecognizer. That overlaps #2176 / #2170, which predate this PR and which I missed when filing (sorry about that). I rescoped this PR to only the parts #2170 doesn't cover, so the two PRs are complementary and can land in either order.Issue reference
Fixes #2217
Checklist