Skip to content

fix(analyzer): register three predefined recognizers missing from default_recognizers.yaml - #2218

Open
juno-junho wants to merge 1 commit into
data-privacy-stack:mainfrom
juno-junho:fix/kr-passport-yaml-entry
Open

fix(analyzer): register three predefined recognizers missing from default_recognizers.yaml#2218
juno-junho wants to merge 1 commit into
data-privacy-stack:mainfrom
juno-junho:fix/kr-passport-yaml-entry

Conversation

@juno-junho

@juno-junho juno-junho commented Aug 4, 2026

Copy link
Copy Markdown

Change Description

Register the three pattern-based predefined recognizers that are exported in code but missing from default_recognizers.yaml: AbaRoutingRecognizer, FiPersonalIdentityCodeRecognizer and SgUenRecognizer. Each entry ships enabled: false with the matching country_code, so default behavior is unchanged while no-code YAML users can discover and enable them. A test flips the three entries on and asserts they instantiate (all three constructors already accept the loader's name kwarg, so these entries are enable-safe on their own).

Scope note: this PR originally also fixed the name-kwarg TypeError on four other recognizers and registered KrPassportRecognizer. That overlaps #2176 / #2170, which predate this PR and which I missed when filing (sorry about that). I rescoped this PR to only the parts #2170 doesn't cover, so the two PRs are complementary and can land in either order.

Issue reference

Fixes #2217

Checklist

  • I have reviewed the contribution guidelines
  • I agree to follow this project's Code of Conduct
  • I confirm that I have the right to submit this contribution and that it does not knowingly contain proprietary or confidential code.
  • My code includes unit tests
  • All unit tests and lint checks pass locally
  • My PR contains documentation updates / additions if required

@juno-junho
juno-junho force-pushed the fix/kr-passport-yaml-entry branch 2 times, most recently from 1e22643 to 354f8ce Compare August 5, 2026 01:08
@juno-junho juno-junho changed the title fix(analyzer): accept the loader's name kwarg in bundled recognizers and add four missing yaml entries fix(analyzer): register three predefined recognizers missing from default_recognizers.yaml Aug 5, 2026
@juno-junho
juno-junho force-pushed the fix/kr-passport-yaml-entry branch from 354f8ce to 7221d7e Compare August 5, 2026 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Three pattern recognizers are missing from default_recognizers.yaml (AbaRouting, FiPersonalIdentityCode, SgUen)

1 participant