Merged
Conversation
Wire the existing group label to schedule list so users can filter schedules by group. The ListHandler now accepts a ListRequest with an optional Group field. Empty group returns all schedules.
Use GORM struct-based Where and UpdateColumn instead of raw SQL with backtick quoting, which fails on Postgres.
parkan
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--groupfilter flag tosingularity deal schedule listso users can filter schedules by group labelListHandlernow acceptsListRequestwith optionalGroupfield (empty = all schedules)Follow-up to #651 per parkan's review comment about wiring group to other schedule commands. The
--groupflag was already present onschedule update— this adds it toschedule list.Test plan
go build ./...— compiles cleango vet ./...— no issuesgo test ./handler/deal/schedule/... ./cmd/... ./api/...— all pass