fix(storages): resolve departmentName in file storage user organizations - #138
Merged
Conversation
The file storage builds user.organizations from the organizations members but only copies the department id: the session token of a department member carries department without departmentName, so sessionState.account.departmentName is undefined in every consuming service (data-fair reads it to suffix _ownerName on the own/ routes). The mongo storage persists departmentName on the user document, and findMembers already resolves it from the organization departments; apply the same resolution in getUserOrgas.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve
departmentNamewhen buildinguser.organizationsin the file storage backend.What changed:
departmentNamefromorga.departmentsingetUserOrgaswhen a member has adepartmentID.departmentanddepartmentNameare correctly populated onuser.organizations.Why:
When using
FileStorage,getUserOrgasonly copied the department ID (member.department) onto the member record without resolving its display name (departmentName). As a result, the session token lackeddepartmentName(leavingsessionState.account.departmentNameundefined), breaking consuming services like Data-Fair which rely on it to suffix_ownerNameon/own/*routes.The Mongo storage backend already stores and resolves
departmentName, andFileStorage.findMemberswas already performing this resolution.