chore(ui): bump vuetify to 4.1 and vjsf to 4.5.3 - #32
Merged
Conversation
vjsf imports VColorInput statically, and the import path follows vuetify: labs/VColorInput up to vjsf 4.5.2, components/VColorInput from 4.5.3 on (vuetify 4.1 promoted the component from labs to core). The two packages must therefore move together: the previous ranges (vjsf ^4.2.0 with vuetify ^4.0.3) held only by lockfile luck and would have broken the build on the next npm update. Resolved versions: vuetify 4.1.11, vjsf 4.5.4.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@koumoul/vjsfimportsVColorInputstatically innodes/index.js(throughcolor-picker.vue), so the path is resolved at build time even when no schema uses a color picker. And that path follows vuetify:vuetify/labs/VColorInputup to vjsf 4.5.2,vuetify/components/VColorInputfrom 4.5.3 on, because vuetify 4.1 promoted the component from labs to core.uideclared@koumoul/vjsf: ^4.2.0next tovuetify: ^4.0.3— a pair that held only by lockfile luck (vjsf 4.3.0 with vuetify 4.0.5). The nextnpm updateresolves vjsf ≥4.5.3 while vuetify stays on 4.0.x, and the UI build fails on an unresolvedvuetify/components/VColorInput. Both ranges are raised together:vuetify: ^4.1.0(resolved 4.1.11) and@koumoul/vjsf: ^4.5.3(resolved 4.5.4), which brings@json-layout/core2.7.1 → 2.8.2 and@json-layout/vocabulary2.13.0 → 2.13.1.Why: the coupling is invisible in
package.jsonand breaks in both directions — vjsf ≥4.5.3 against vuetify 4.0.x looks for acomponents/VColorInputthat does not exist yet, vuetify ≥4.1 against vjsf ≤4.5.2 looks for alabs/VColorInputthat is gone. Nothing in the declared ranges enforced the pairing, so it was one dependency refresh away from a red build. vjsf 4.5.3+ peer depends onvuetify ^4.1.0, which now matches what this repo declares.Heads-up:
vuetify/labs/*import inui/src, nor in@data-fair/lib-vuetify2.3.0, so the labs → core promotion needs no code change here: the two ranges are the whole diff.base-color="warning"checkbox of the delete-import dialog and a few indeterminate progress circulars.lint,build-types,check-types,vue-tscon the ui, the ui build and the 26 tests of theunitproject pass locally. Theapiande2eprojects were not run on my machine (they need the dev services up), CI covers them.