Skip to content

chore: update minimum chain work, tx stats, checkpoints, seeds for v23.1#7137

Merged
PastaPastaPasta merged 5 commits intodashpay:developfrom
kwvg:v23.1_params
Feb 13, 2026
Merged

chore: update minimum chain work, tx stats, checkpoints, seeds for v23.1#7137
PastaPastaPasta merged 5 commits intodashpay:developfrom
kwvg:v23.1_params

Conversation

@kwvg
Copy link
Collaborator

@kwvg kwvg commented Feb 13, 2026

Additional Information

  • SECURITY.md remains unchanged for minor releases.

  • The blocks used as checkpoints are

    • For mainnet, block 2361500 (0x000000000000000718ed026ebd644a8b70b42d4cbd7b25304c066c9bf15f85b7, Insight)
    • For testnet, block 1239600 (0x000000a98084beaf77ed26a905a7d59979009e23367a55b5d634962d7d65a1f9, Insight)
  • m_assumed_{blockchain,chain_state}_size calculations

    • Mainnet synced till block 2421861, Dash Core v23.0.2 (release)

      $ du --exclude ~/.dashcore/testnet3 --max-depth=0 -h ~/.dashcore
      52G     /home/debian/.dashcore
      $ python3 -c "print(round(52*1.1))" # 10% leeway
      57
      $ du --max-depth=0 -h ~/.dashcore/chainstate
      241M    /home/debian/.dashcore/chainstate

      As m_assumed_chain_state_size is still <1GB, we don't update it

    • Testnet synced till block 1420138, Dash Core v23.0.2 (release)

      $ du --max-depth=0 -h ~/.dashcore/testnet3
      8.9G     /home/debian/.dashcore/testnet3
      $ python3 -c "print(round(8.9*1.1))" # 10% leeway
      10
      $ du --max-depth=0 -h ~/.dashcore/testnet3/chainstate
      76M    /home/debian/.dashcore/chainstate

      m_assumed_blockchain_size remains unchanged for testnet.

  • Mainnet seeds generated using protx list valid 1 2421861, testnet seeds generated using protx list valid 1 1420138, commenting out deduplication (source) and raising the MAX_SEEDS_PER_ASN to 10 (source)

Breaking Changes

None expected.

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas (note: N/A)
  • I have added or updated relevant unit/integration/functional/e2e tests (note: N/A)
  • I have made corresponding changes to the documentation (note: N/A)
  • I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

@kwvg kwvg added this to the 23.1 milestone Feb 13, 2026
@github-actions
Copy link

✅ No Merge Conflicts Detected

This PR currently has no conflicts with other open PRs.

@kwvg kwvg marked this pull request as ready for review February 13, 2026 11:03
@coderabbitai
Copy link

coderabbitai bot commented Feb 13, 2026

Walkthrough

This pull request updates seed node lists and chain parameters across multiple configuration files. Changes include replacement of onion and IPv4 seed node entries in contrib/seeds files, updates to consensus checkpoints in src/chainparams.cpp (nMinimumChainWork, defaultAssumeValid, chainTxData with new height references), and corresponding updates to the serialized seed arrays in src/chainparamsseeds.h. No functional logic or control flow is modified; all changes are data-only, affecting node discovery configuration and chain progress validation points.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Suggested reviewers

  • knst
  • PastaPastaPasta
  • UdjinM6
🚥 Pre-merge checks | ✅ 3 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The pull request title accurately describes the main changes: updating minimum chain work, transaction stats, checkpoints, and seed data for v23.1 release.
Description check ✅ Passed The pull request description provides relevant details about the changes, including specific block checkpoints, size calculations, seed generation methodology, and explicitly notes no breaking changes.
Merge Conflict Detection ✅ Passed ✅ No merge conflicts detected when merging into develop

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

No actionable comments were generated in the recent review. 🎉


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Member

@PastaPastaPasta PastaPastaPasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK ea43d38

@PastaPastaPasta PastaPastaPasta merged commit 3124895 into dashpay:develop Feb 13, 2026
44 of 46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants