Skip to content

Conversation

@UdjinM6
Copy link

@UdjinM6 UdjinM6 commented Jan 17, 2026

Issue being fixed or feature implemented

src/wallet/bip39_english.h:1739: sting ==> string

https://github.com/dashpay/dash/actions/runs/21038475212/job/60493347838#step:5:71

warning: '/__w/dash/dash/build-ci/dashcore-linux64_multiprocess/src/threadinterrupt.cpp' not found on disk.

https://github.com/dashpay/dash/actions/runs/21038475212/job/60493578607#step:12:977

What was done?

How Has This Been Tested?

Breaking Changes

n/a

Checklist:

Go over all the following points, and put an x in all the boxes that apply.

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation
  • I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

- ci/dash/lint-tidy.sh: fix src/threadinterrupt.cpp to
  src/util/threadinterrupt.cpp and sort entries
- test/lint/lint-spelling.py: fix src/bip39_english.h to
  src/wallet/bip39_english.h and move it to the end of the list
- contrib/devtools/copyright_header.py: remove stale exclusion for
  test/functional/test_framework/bignum.py (removed in 11bcc75)

Co-Authored-By: Claude Opus 4.5 <[email protected]>
@UdjinM6 UdjinM6 added this to the 23.1 milestone Jan 17, 2026
@github-actions
Copy link

⚠️ Potential Merge Conflicts Detected

This PR has potential conflicts with the following open PRs:

Please coordinate with the authors of these PRs to avoid merge conflicts.

@coderabbitai
Copy link

coderabbitai bot commented Jan 17, 2026

Walkthrough

This pull request contains minor configuration updates across three linting and build tool scripts. The changes relocate or update file references within exclusion and inclusion lists: a C++ source file is moved from src/ to src/util/ in the include-what-you-use tool configuration, an exclusion pattern is removed from copyright header scanning, and a header file path is updated from src/ to src/wallet/ in spelling lint exclusions. These updates appear to reflect corresponding file structure reorganizations in the codebase.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: adjusting/removing incorrect file paths in CI and linting scripts.
Description check ✅ Passed The description references the specific issues being addressed (spelling error and missing file warnings) and links to the CI logs where these issues were reported.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant