feat: split OMIT_IO into OMIT_PROMPTS and OMIT_TOOL_IO#111
Open
k-berger wants to merge 2 commits into
Open
Conversation
Allows independently opting in/out of prompt content vs tool call I/O collection. Both default to true, preserving the previous OMIT_IO=true default. The old OMIT_IO option is removed (hard break).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OMIT_IOprivacy flag into two independent flags:OMIT_PROMPTS(gates user prompts + assistant responses) andOMIT_TOOL_IO(gates tool call inputs + responses). Both default totrue, matching the previousOMIT_IO=truedefault — so out-of-the-box behavior is unchanged.OMIT_PROMPTS=true,OMIT_TOOL_IO=false), or the reverse.OMIT_IOis removed entirely, no alias. Users who explicitly setOMIT_IO=falseto enable collection will need to migrate to the new flags; users on defaults are unaffected.Implementation:
contentKeysmap ininternal/otlp/otlp.gosplits intopromptContentKeys+toolContentKeys, and the redaction branch ineventAttributesbecomes(cfg.OmitPrompts && promptContentKeys[k]) || (cfg.OmitToolIO && toolContentKeys[k]). Wired throughConfig,cmd/on-event/main.go, theuserConfigdeclarations inplugin.json, the YAML frontmatter parser inscripts/on-event.sh, andDASH0_*env var fallbacks. README updated across the privacy defaults table, configuration tables, env var table, config file examples, and attribute footnotes.Test plan
go build ./...cleango test ./...— all packages pass (unit + integration)TestSendLogOmitIOinto three sub-tests (both flags, prompts-only, tool-IO-only); split tool/LLM span tests intrace_test.goto verify each flag is wired to the right span type; renamed*SurvivesOmitIOextraction tests to*SurvivesOmitToolIOand switched their env varCLAUDE_PLUGIN_OPTION_OMIT_PROMPTS=falseandCLAUDE_PLUGIN_OPTION_OMIT_TOOL_IO=falseOMIT_PROMPTS=true+OMIT_TOOL_IO=false, confirm only tool I/O reaches Dash0OMIT_IO=false