Remove package:built_value dependency from HotReloadRequest #2729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

jyameo wants to merge 1 commit into dart-lang:main from jyameo:jy-rm-built

+624 −846

Contributor

jyameo commented Dec 19, 2025

Changes

Rewrote HotReloadRequest as a simple Dart class with manual JSON serialization
Replaced builder pattern constructor with standard named parameter constructor
Implemented fromJson() factory and toJson() method for JSON serialization
Removed HotReloadRequest from built_value serializers annotation
Updated usage in WebSocketProxyService to use new constructor syntax

Testing

Existing tests for hot reload functionality continue to pass with the updated implementation.


          updated HotReloadRequest to use JSON serialization

85503ba

github-actions bot added the package:dwds label

jyameo requested review from bkonyi and nshahan

December 19, 2025 21:12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels