Allow similar use between sync and async checks#2683
Open
natebosch wants to merge 3 commits into
Open
Conversation
Towards #2639 Originally async expectations which extract a value also returned a `Subject` like synchronous extensions still do, but they were changed to accept `AsyncCondition` callback arguments for ergonomics. Add support for synchronous `Condition` callbacks on a few expectations that return subjects for authors who prefer to use the async style for synchronous checks too. Affected APIs: - `Subject.isA` - `Subject.isNotNull` - `Subject<T Function()>.throws` - `Subject<T Function()>.returnsNormally` Restore the `Future<Subject>` return value from async check extensions that accept an optional `AsyncCondition` argument. This allows usage of other patterns which some authors may feel are better aligned with the sync checks of the original pattern. Affected APIs: - `Subject<Future>.completes` - `Subject<Future>.throws` - `Subject<StreamQueue>.emits` - `Subject<StreamQueue>.emitsError` Refactor tests into finer grained cases and add cases for the new arguments.
PR HealthChangelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. This check can be disabled by tagging the PR with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards #2639
Originally async expectations which extract a value also returned a
Subjectlike synchronous extensions still do, but they were changed toaccept
AsyncConditioncallback arguments for ergonomics. Add supportfor synchronous
Conditioncallbacks on a few expectations that returnsubjects for authors who prefer to use the async style for synchronous
checks too.
Affected APIs:
Subject.isASubject.isNotNullSubject<T Function()>.throwsSubject<T Function()>.returnsNormallyRestore the
Future<Subject>return value from async check extensionsthat accept an optional
AsyncConditionargument. This allows usage ofother patterns which some authors may feel are better aligned with the
sync checks of the original pattern.
Affected APIs:
Subject<Future>.completesSubject<Future>.throwsSubject<StreamQueue>.emitsSubject<StreamQueue>.emitsErrorRefactor tests into finer grained cases and add cases for the new
arguments.