WIP: Claude Code plugin#511
Conversation
PR HealthChangelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. This check can be disabled by tagging the PR with |
There was a problem hiding this comment.
Code Review
This pull request introduces a bash script to sync Dart and Flutter skills, Claude plugin configuration files, and a comprehensive collection of skill guides for Dart and Flutter development. The review feedback highlights a few necessary corrections, including removing an invalid trailing comma in the marketplace JSON configuration, adding a trap to guarantee temporary directory cleanup in the sync script, and fixing minor typos and syntax errors in the skill documentation.
| { | ||
| "name": "dart-flutter-marketplace", | ||
| "owner": { | ||
| "name": "Dart and Flutter Team", |
| fi | ||
|
|
||
| TARGET_DIR="$REPO_ROOT/plugins/skills" | ||
| TEMP_DIR=$(mktemp -d) |
There was a problem hiding this comment.
[CONCERN] Since the script is run with set -e, any failure during cloning or syncing will cause the script to exit immediately, leaving the temporary directory behind. Consider using a trap to guarantee cleanup of the temporary directory on exit.
| TEMP_DIR=$(mktemp -d) | |
| TEMP_DIR=$(mktemp -d)\ntrap 'rm -rf "$TEMP_DIR"' EXIT |
| ..has((e) => e.message, 'message').equals('invalid input'); | ||
|
|
||
| // NO (Passing a callback to sync throws will cause a compiler error!) | ||
| check(() => triggerSync").throws<ArgumentError>((it) => ...); // ERROR! |
There was a problem hiding this comment.
[CONCERN] There is a typo/syntax error in the code example: triggerSync" has an unmatched double quote and is missing parentheses. It should be triggerSyncError() to match the correct function name used in the previous example.
| check(() => triggerSync").throws<ArgumentError>((it) => ...); // ERROR! | |
| check(() => triggerSyncError()).throws<ArgumentError>((it) => ...); // ERROR! |
| @@ -0,0 +1,141 @@ | |||
| --- | |||
| name: dart-collect-coverage | |||
| description: Collect coverage using the coverage packge and create an LCOV report | |||
|
Here's what I got when I ran |
|
Thanks for validating the plugin. Added a description for the marketplace, and version info to plugin. |
Work in Progress : to test before sending for review
Bundle the Dart and Flutter plugins into a plugin for Claude Code.