Fix Python sdist missing csrc/src: add to MANIFEST.in#144
Merged
Conversation
Co-authored-by: darnstrom <[email protected]> Agent-Logs-Url: https://github.com/darnstrom/daqp/sessions/4c009764-94a8-459a-bee5-ec5451d1db6b
Copilot
AI
changed the title
[WIP] Fix Python interface setup for successful uploads
Fix Python sdist missing csrc/src: add to MANIFEST.in
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
MANIFEST.inonly includedcsrc/include/*but notcsrc/src/*.c, so the sdist uploaded to PyPI was missing the C sources required to compile the Cython extension. Installing from PyPI or runningpython -m buildwould fail at wheel build with:Change
interfaces/daqp-python/MANIFEST.in: addrecursive-include csrc/src *so all C source files are bundled in the sdist alongside the existing headers.📍 Connect Copilot coding agent with Jira, Azure Boards or Linear to delegate work to Copilot in one click without leaving your project management tool.