Draft
Conversation
CONT_DESTROY handling employs one RDB TX and invokes a CONT_TGT_DESTROY
CoRPC synchronously during the RDB TX. This is related to the following
problems:
- DAOS-18190: A partially-destroyed container remains openable,
leading to false positive "corruptions".
- DAOS-18301: The CONT_TGT_DESTROY CoRPC may trigger deadlocks on
cs_lock.
This patch addresses both problems by splitting CONT_DESTROY handling
such that a first RDB TX marks the container as DESTROYING (i.e.,
having entered the state of being destroyed), the CONT_TGT_DESTROY CoRPC
goes without holding cs_lock, and a second RDB TX destroys the container
from the RDB.
Although not openable, DESTROYING containers still appear in container
list results, and may need re-destroying. This is to minimize changes
and focus on the most important problems first; further improvements
will come next.
Test-tag: pr test_ec_online_rebuild
Signed-off-by: Li Wei <liwei@hpe.com>
Test-tag: pr test_ec_online_rebuild
Test-tag: daily_regression Signed-off-by: Wang Shilong <shilong.wang@hpe.com>
|
Errors are component not formatted correctly,Ticket number prefix incorrect,PR title is malformatted. See https://daosio.atlassian.net/wiki/spaces/DC/pages/11133911069/Commit+Comments,Unable to load ticket data |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Steps for the author:
After all prior steps are complete: