Skip to content

DAOS-18688 client: Fix Lustre detection logic with the ASAN lib#17756

Open
knard38 wants to merge 1 commit intomasterfrom
ckochhof/fix/master/daos-18688/patch-001
Open

DAOS-18688 client: Fix Lustre detection logic with the ASAN lib#17756
knard38 wants to merge 1 commit intomasterfrom
ckochhof/fix/master/daos-18688/patch-001

Conversation

@knard38
Copy link
Contributor

@knard38 knard38 commented Mar 23, 2026 •
edited
Loading

Description

This patch corrects a bug where Lustre was not detected if libasan was enabled via the SANITIZERS variable. The detection logic now works correctly regardless of sanitizer settings.

Steps for the author:

  • Commit message follows the guidelines.
  • Appropriate Features or Test-tag pragmas were used.
  • Appropriate Functional Test Stages were run.
  • At least two positive code reviews including at least one code owner from each category referenced in the PR.
  • Testing is complete. If necessary, forced-landing label added and a reason added in a comment.

After all prior steps are complete:

  • Gatekeeper requested (daos-gatekeeper added as a reviewer).

@kanard38 @knard38
DAOS-18688 client: Fix Lustre detection logic with the ASAN lib
2e30a6b 
This patch corrects a bug where Lustre was not detected if libasan was
enabled via the SANITIZERS variable. The detection logic now works
correctly regardless of sanitizer settings.

Signed-off-by: Cedric Koch-Hofer <cedric.koch-hofer@hpe.com>
@knard38 knard38 self-assigned this Mar 23, 2026
@knard38 knard38 added the bug label Mar 23, 2026
@github-actions
Copy link

github-actions bot commented Mar 23, 2026 •
edited
Loading

Ticket title is 'daos fails to compile when lustre is installed'
Status is 'In Review'
Labels: 'ORNL'
Job should run at elevated priority (1)
https://daosio.atlassian.net/browse/DAOS-18688

@knard38 knard38 marked this pull request as ready for review March 23, 2026 19:51
@knard38 knard38 requested review from a team as code owners March 23, 2026 19:51
@knard38 knard38 requested review from daltonbohning and removed request for daltonbohning March 23, 2026 19:52
@daosbuild3
Copy link
Collaborator

daosbuild3 commented Mar 24, 2026

Test stage Functional on EL 9 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17756/1/execution/node/1060/log

@knard38 knard38 requested a review from mchaarawi March 24, 2026 20:16
@knard38
Copy link
Contributor Author

knard38 commented Mar 24, 2026

@mrgriffith validated the patch with lustre ORNL node.
My apologies @mrgriffith , I was not able to add you as a reviewer of the PR.

@daosbuild3
Copy link
Collaborator

daosbuild3 commented Mar 24, 2026

Test stage Functional on EL 9 completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-17756/2/testReport/

@mrgriffith
Copy link
Contributor

mrgriffith commented Mar 24, 2026

@mrgriffith validated the patch with lustre ORNL node. My apologies @mrgriffith , I was not able to add you as a reviewer of the PR.

No worries. Yeah, we were able to build DAOS with the lustre client installed at ORNL for this patch. However, just to make note, we never tried the ASAN enabled version. That was not on our radar at this point.

@github-actions github-actions bot added the priority Ticket has high priority (automatically managed) label Mar 25, 2026
@daosbuild3
Copy link
Collaborator

daosbuild3 commented Mar 25, 2026

Test stage Functional on EL 9 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17756/3/execution/node/1039/log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mchaarawi mchaarawi mchaarawi approved these changes

@daltonbohning daltonbohning daltonbohning approved these changes

Assignees

@knard38 knard38

Labels

bug priority Ticket has high priority (automatically managed)

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@knard38 @daosbuild3 @mrgriffith @mchaarawi @daltonbohning @kanard38