Switch to uncrustify

[danmar]

No description provided.

[danmar]

@jcfr feel free to review

[jcfr]

Thanks for working on this:

1. Considering cherry picking commit titled chore: Remove obsolete runastyle scripts from #516

2. Add a second commit

   chore: Add settings corresponding to uncrustify 0.80.1
   
   Introduce settings based of similar settings copied from 
   danmar/cppcheck@b4f07cdbb.
   

3. Add a third commit:

   style: Consistent formatting of C++ sources using uncrustify
   
   This commit updates the sources file based on the settings
   introduced in previous commit.
   

4. Either in the context of this pull request or in a follow-up one, add .git-blame-ignore-revs¹

5. Add pre-commit.yml workflow with the uncrustify hook enabled².

Footnotes

1. https://docs.github.com/en/repositories/working-with-files/using-files/viewing-and-understanding-files#ignore-commits-in-the-blame-view ↩

2. https://github.com/pocc/pre-commit-hooks ↩

[danmar]

@jcfr thanks for the reviews. there was some mess in my first commit to cleanup as you saw. but I hope it didn't add any extra changes now.

[jcfr]

This is likely incorrect and inconsistent, inspecting danmar/cppcheck@3726ace seems to indicate that the version should be 0.80.1

[danmar]

I agree. I copied the file directly from cppcheck main though. :-( maybe we need to update the script both in cppcheck and simplecpp..

[danmar]

maybe we need to update the script both in cppcheck and simplecpp..

would you have time to look at that maybe?

[jcfr]

The commit should probably have been split as suggested in #517 (review). Indeed, referencing 18cfb6a in .git-blame-ignore-revs will now incorrectly ignore non stylistic changes.

While this is not a critical in the current situation, in the future, I suggest to avoid mixing changes.