Skip to content

Fix #14155 FP resourceLeak with socket() and windows.cfg #8133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chrchr-github merged 2 commits into from
Jan 20, 2026
Merged

Fix #14155 FP resourceLeak with socket() and windows.cfg #8133

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f0d75d4
Update windows.cfg
chrchr-github Jan 19, 2026
bcb34b8
Update windows.cpp
chrchr-github Jan 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cfg/windows.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7191,7 +7191,7 @@ HFONT CreateFont(
<define name="AFX_EXT_CLASS" value=""/>
<define name="DEBUG_NEW" value="new"/>
<define name="INVALID_HANDLE_VALUE" value="-1"/>
<define name="INVALID_SOCKET" value="~0"/>
<define name="INVALID_SOCKET" value="-1"/>
<define name="WINAPI" value="__stdcall"/>
<define name="STDMETHODCALLTYPE" value="__stdcall"/>
<define name="STDMETHODIMP" value="HRESULT STDMETHODCALLTYPE"/>
Expand Down
7 changes: 7 additions & 0 deletions test/cfg/windows.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,13 @@ void invalid_socket()
// cppcheck-suppress resourceLeak
}

void invalid_socket_noleak(int a, int t, int p) { // #14155
SOCKET s = socket(a, t, p);
if (s == INVALID_SOCKET)
return;
closesocket(s);
}

void resourceLeak_OpenThread(const DWORD dwDesiredAccess, const BOOL bInheritHandle, const DWORD dwThreadId)
{
HANDLE proc = OpenThread(dwDesiredAccess, bInheritHandle, dwThreadId);
Expand Down
Loading