Skip to content

Fix #13220 FN nullPointerRedundantCheck with constructor (regression) #8132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chrchr-github merged 3 commits into from
Jan 21, 2026
+11 −1
Merged

Fix #13220 FN nullPointerRedundantCheck with constructor (regression) #8132

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0e9fc7d
Update checknullpointer.cpp
chrchr-github Jan 19, 2026
19dd97c
Update testnullpointer.cpp
chrchr-github Jan 19, 2026
e84e60d
Update checknullpointer.cpp
chrchr-github Jan 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/checknullpointer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,7 +310,8 @@ void CheckNullPointer::nullPointerByDeRefAndCheck()

return true;
};
std::vector<const Token *> tokens = findTokensSkipDeadAndUnevaluatedCode(mSettings->library, scope->bodyStart, scope->bodyEnd, pred);
const Token* const start = (scope->function && scope->function->isConstructor()) ? scope->function->token : scope->bodyStart; // Check initialization list
std::vector<const Token *> tokens = findTokensSkipDeadAndUnevaluatedCode(mSettings->library, start, scope->bodyEnd, pred);
for (const Token *tok : tokens) {
const ValueFlow::Value *value = tok->getValue(0);

Expand Down
9 changes: 9 additions & 0 deletions test/testnullpointer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3742,6 +3742,15 @@ class TestNullPointer : public TestFixture {
" return 1 ? 1 : *(int*)0 = 1;\n"
"}\n");
ASSERT_EQUALS("", errout_str());

check ("struct S {\n" // #13220
" explicit S(int* p) : i(*p) {\n"
" if (p) {}\n"
" }\n"
" int i;\n"
"};\n");
ASSERT_EQUALS("[test.cpp:3:13] -> [test.cpp:2:29]: (warning) Either the condition 'p' is redundant or there is possible null pointer dereference: p. [nullPointerRedundantCheck]\n",
errout_str());
}

void nullpointerDelete() {
Expand Down
Loading