fix(ActivityParser): Add cross-platform path support for Linux#433
Open
ecielam wants to merge 1 commit intodanielmiessler:mainfrom
Open
fix(ActivityParser): Add cross-platform path support for Linux#433ecielam wants to merge 1 commit intodanielmiessler:mainfrom
ecielam wants to merge 1 commit intodanielmiessler:mainfrom
Conversation
Problem:
ActivityParser.ts hardcoded macOS-specific path pattern `-Users-${USERNAME}--claude`
for the Claude Code projects directory. This fails on Linux systems where the
home directory is `/home/` instead of `/Users/`.
Solution:
- Import `os` module for platform detection
- Use `os.platform()` to detect macOS ("darwin") vs Linux
- Dynamically construct PATH_PREFIX: "Users" on macOS, "home" on Linux
- Replace `require("os")` with proper `os` import for consistency
This is the same fix pattern applied to SessionHarvester.ts.
Tested on:
- Linux (Ubuntu): Correctly resolves to `-home-username--claude`
- Expected macOS behavior: `-Users-username--claude`
Co-Authored-By: Claude Opus 4.5 <[email protected]>
alessandro-estate-guru
left a comment
There was a problem hiding this comment.
While you're in here, maybe just add windows support as well? If you add this, I'd do this in a switch instead of ternary to make it more legible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ActivityParser.ts hardcodes macOS-specific path pattern
-Users-${USERNAME}--claudefor the Claude Code projects directory. This fails on Linux systems where home directories are under/home/instead of/Users/.This is the same issue fixed in #[SessionHarvester PR number] for SessionHarvester.ts.
Changes
Testing
Linux (Ubuntu 24.04):
-home-username--claudemacOS (expected):
-Users-username--claude(unchanged behavior)Checklist
osmodule)