Use cached namespace validation#1149
Conversation
Codecov ReportBase: 88.27% // Head: 88.25% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #1149 +/- ##
==========================================
- Coverage 88.27% 88.25% -0.02%
==========================================
Files 73 73
Lines 8800 8803 +3
==========================================
+ Hits 7768 7769 +1
- Misses 1032 1034 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Thank you @CodyCBakerPhD and sorry I've missed it whenever you originally filed it. Looks good to me and is Green (freshier PRs aren't as lucky due to some disturbance in the Force). So I will not delay merging it as is. I think we can stick to not demand upgraded pynwb for a bit longer but might soon as well beef it up. |
Fixes #917
Which came from dandi/helpdesk#43
Replaces #1036
Newest version of PyNWB supports validation against cached namespaces (and indeed this is now the default).
I've updated the usage here in a minimal way to both support older PyNWB versions (my other thought was to bump the version in the
setup.cfg, but IDK what your policy or view is on that) that do not offer this feature as well as the newest version that supports it as a simple adjustment to the way thepynwb.validatefunction is called.