Fix dirty submodule state in short output#2179
Open
dpersek wants to merge 1 commit into
Open
Conversation
Preserve the -dirty suffix when shortening submodule commit IDs so short submodule diffs show dirty working tree state.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #1838.
It preserves the '-dirty' suffix when delta renders short submodule diffs. The commit hash is still shortened as before, but the dirty marker is no longer dropped. I added focused coverage for clean and dirty submodule commit lines and updated the existing dirty submodule fixture.
Tests run:
AI note: I used AI assistance for the implementation/testing pass and reviewed the diff locally before opening this.