Discord theme tweaks#2162
Open
ILikePlayingGames wants to merge 1 commit into
Open
Conversation
- Replace ANSI codes with their colour names - Make zero style white instead of black for better readability in dark mode - Change plus-emph and minus-emph background colours to be closer to their non-emph counterparts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Comparison
Before
After
Notes
In Discord, there is no way to have different outputs depending on what theme the user is using, so one delta theme must work for all Discord themes. It's not as apparent in screenshots, but the black and the background had too little contrast difference for OLED users such that it was almost impossible to read. Unfortunately with the white, the contrast on light mode is now not ideal, but still readable. It is difficult to find a shade that works ideally for both themes.