A couple of small improvements to CraftOS#566
Open
SquidDev wants to merge 1 commit intodan200:masterfrom
Open
Conversation
Rems19
reviewed
Dec 26, 2018
src/main/resources/assets/computercraft/lua/rom/apis/window.lua
Outdated
Show resolved
Hide resolved
- Make window.reposition's argument validation a little more strict. Previously it would accept `window.reposition(x, y, width)` (no height argument), just not act upon it. - Use select instead of table.unpack within `pastebin run`. - Use `parallel.waitForAny` instead of `waitForAll` within the dance program. - Pipe the entire help file into `textutils.pagedPrint`, rather than doing it line by line. - Remove bytecode loading disabling from bios.lua. This never worked correctly, and serves little purpose as LuaJ is not vulnerable to such exploits.
SquidDev
force-pushed
the
feature/tiny-lua-wins
branch
from
de13079 to
226000d
Compare
ccserver
pushed a commit
to ccserver/ComputerCraft
that referenced
this pull request
Sep 16, 2019
…tiny-lua-wins A couple of small improvements to CraftOS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
window.reposition(x, y, width)(no height argument), just not act upon it.pastebin run.parallel.waitForAnyinstead ofwaitForAllwithin the dance program.textutils.pagedPrint, rather than doing it line by line.I realise many of these changes are incredibly minor, and so don't really seem worth it. However, CraftOS is a great reference to link people to when they're looking for help, and so it's always good if we can show "best practices" for using CC & Lua's features.
If anyone else has changes that really aren't worth a separate PR, feel free to let me know/send a patch.