Add direct stale-fallback coverage for news updater main flow#157
Merged
dai merged 2 commits intoJul 10, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The news updater’s stale-output fallback was only covered indirectly. This change adds direct
main()-level coverage for the branch that decides whether an all-source failure should preserve the existingnews.jsonor fail the run.What changed
scripts/update_news_feed.py::main()--allow-stale-on-failureis enabled0without rewriting the file--allow-stale-on-failureis enabled1Why this matters
Test shape
Scope
scripts/update_news_feed_test.py