Fix version and renamed custom_malloc to custom_alloc - #41
Conversation
obbardc
left a comment
obbardc
left a comment
There was a problem hiding this comment.
LGTM, I will pick this for the Debian package.
Tiny nitpick: I would split it into two commits though as they are two separate changes. But I doubt that really matters too much.
|
I could split the changes into two commits. About the version change would that require a new tag? |
I guess it would make more sense to get a new release tagged e.g. 1.1.1 with the correct metadata :-) |
|
I split the changes into two and modified the version so all that is needed to tag future releases is to change |
obbardc
left a comment
obbardc
left a comment
There was a problem hiding this comment.
Small nitpick about possibly autodeterminjng the version to not let the version go out of sync; otherwise looking good!
|
Although this does make it depend on git to get the version |
obbardc
left a comment
obbardc
left a comment
There was a problem hiding this comment.
Looks good, tested well, one small nitpick !
2 participants
The wrong version was exported in the .pc file and cmake.
also there was an abi change where ic_init_custom_alloc is declated in isocline.h but is not implemented in isocline.c