History refurbish - #22
Open
jorbakk wants to merge 87 commits into
Open
Conversation
This would lead to inconsistencies with showing/hiding and handling the history entries.
Implementation is most likely not fully correct ... it's just to show that the original backend should also work with the new API.
Implementation not tested ...
Owner
|
Thank you for your PR! and apologies for the late reply. I like the idea but I am very hesitant to merge this as it creates a big dependency. It is a bit too much for the scope of this project. I will leave the PR up though for others that may want to include this. Thanks again. |
Author
|
You're very welcome. Thanks for starting this great project in the first place! I actually use it as a daily driver (repline) for my shell (plan9 rc shell, rci) since about 3 years with some improvements along the line and I'm quite happy. Replacing sqlite3 by something simpler is still on my list ... though I think it's okay for the interactive UI part of a repl/interpreter which should be an optional user interface and available separately. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New backend for handling a large number of history entries along with a different user interface for handling the history:
The sqlite backend adds a dependency and could be replaced by e.g. a memory mapped file in the long run. However, currently it's easier to explore more advanced features with the sqlite backend. Advanced features could be: