fix(page-cluster): add missing build-cluster-reason exports entry - #931
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@d-zero/page-clusterのpackage.jsonのexportsに./build-cluster-reasonエントリが未登録で、Node のサブパスエクスポート制約によりimport { buildClusterReason } from '@d-zero/page-cluster/build-cluster-reason'が解決できなかった不具合を修正dist/build-cluster-reason.js/.d.ts自体は既にビルド・tarball 同梱済みだったため、exportsへの登録のみで解決Test plan
yarn build— 全パッケージビルド成功、dist/build-cluster-reason.{js,d.ts}の生成を確認node --input-type=module -e "import { buildClusterReason } from '@d-zero/page-cluster/build-cluster-reason'; ..."でサブパス解決が実際に成功することを確認yarn lint— エラーなしyarn test— 全118ファイル / 1673テスト成功Closes #930
🤖 Generated with Claude Code