feat: integrate page-cluster's onClusterReason into template clusters - #242
Merged
Conversation
Add page_template_cluster_reasons (template_key PK, no FK, WITHOUT ROWID) alongside page_templates, and thread a ClusterReasonData map through replacePageTemplates so both tables replace atomically in one transaction. New table is provisioned via createAdjunctTables's existing hasTable guard, so existing archives pick it up on next open with no explicit migration.
…luster
Bump @d-zero/page-cluster to 0.5.1 (first published version with
onClusterReason). classifyPageTemplates now wires onClusterReason,
returning { templateKeysByUrl, clusterReasons } instead of a bare Map so
nitpicker.ts can pass both to Archive.replacePageTemplates.
ClusterReason is derived structurally from onClusterReason's own callback
signature rather than imported from page-cluster's non-exported
build-cluster-reason subpath, mirroring the existing stance toward that
library's other non-public internals. The classification cache now stores
both maps together so a crash-recovery cache hit restores clusterReasons
too, not just templateKeysByUrl.
listPageTemplateClusters now attaches the ClusterReason (blocking, structuralCoreTokens, landmarks, siblingClusterKeys) reported for each cluster, read back via the new readClusterReasonsByTemplateKey. `reason` is null for clusters classified before this data existed (page-cluster@0.3.1 era) — distinct from hasClassification: false, which means --templates never ran at all. Remove compute-css-intersection.ts and collect-page-stylesheet-urls-by-page-id.ts: ClusterReason.blocking's css-kind distinctiveStylesheetHrefs is the exact set page-cluster's own first-party/document-frequency filtering already produced, making the prior raw-intersection approximation unnecessary.
…view Add a per-cluster section for blocking evidence (css/path/orphanMerge), DOM-structural core tokens, per-landmark-type chrome commonality, and sibling cluster keys (linked as in-page anchors) — sourced from TemplateClusterSummary.reason. Clusters with reason: null (classified before this data existed) show a re-run-analyze hint in that section only; page count and common directories keep displaying as before. clusterHeading()'s common-stylesheet-filenames priority now reads from the exact blocking evidence instead of the removed raw-intersection approximation, so the former "this list can include site-wide CSS" caveat no longer applies.
Update the template-classification reading path to cover the new table, the ClusterReason collection/persistence flow across core/crawler/query, and the reason-aware viewer display. Also fix a stale filename reference (compute-common-directory.ts -> compute-directory-distribution.ts).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #234.
@d-zero/page-clusterto0.5.1and wire itsonClusterReasoncallback throughclassifyPageTemplates, persisting the reportedClusterReasonper cluster in a newpage_template_cluster_reasonstable (atomic withpage_templateson every--templatesrun).compute-css-intersection.ts) with theexact
distinctiveStylesheetHrefspage-cluster already computed, now surfaced throughlistPageTemplateClustersand the Template Clusters viewer page (blocking evidence, DOMstructural core tokens, per-landmark chrome commonality, sibling clusters).
page-cluster@0.3.1era) show are-run-
--templateshint in the new section only — page count and common directories areunaffected.
Test plan
yarn buildyarn lint:eslint:check(0 errors)yarn test(full workspace, 553 files / 3921 tests)yarn workspace @nitpicker/viewer playwright test --config playwright.template-clusters.config.tsorigin/dev(console-logs feature, PR feat: capture and persist console log entries (issue #228) #241) with conflicts resolved🤖 Generated with Claude Code