fix(repo): forbid client info from leaking into PR body - #844
Merged
Conversation
The PR skill's full-diff re-check only replayed the sample-value convention check, skipping the confidential/client-info check defined in the git skill. PR body generation also had no rule against summarizing session context, so client names could leak in even when the diff itself was clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/prスキルの全体再チェック（ステップ4）に、git/SKILL.mdの「機密・案件情報の検出」を追加。従来は「サンプル値の慣例チェック」のみが対象で、コミット単位のチェックをすり抜けた企業名・顧客情報が PR 全体 diff の再チェックから漏れていたTest plan
yarn lintyarn buildyarn test—server.spec.ts（regression: @burger-editor/local: 起動時 loadResolverState 失敗の終了挙動にテストがない #754）で CLI が 8 秒以内に終了しないタイムアウトが 2 件発生。同時実行中の別テストでENOSPC（disk full）も出ており、Docker 環境のリソース逼迫による flaky と判断。本変更（.claude/skills/pr/SKILL.mdの markdown のみ）は CLI プロセスの挙動に影響しない