Skip to content

test(local): raise server.spec.ts CLI-exit timeout and log actual duration #843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
YusukeHirao merged 1 commit into from
Aug 1, 2026
+15 −4
Merged

test(local): raise server.spec.ts CLI-exit timeout and log actual duration #843

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 15 additions & 4 deletions packages/@burger-editor/local/src/commands/server.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,13 @@ type CliResult = {
* signals. {@link tsxCli} lets us run the source `.ts` entry without first
* building, so the test stays self-contained.
* @param cwd
* @param timeoutMs
* @param timeoutMs Defaults to 20_000ms — generous enough to absorb tsx's
* cold-start compile cost under Docker/QEMU CPU contention with the other
* projects' concurrently-running Playwright browser instances (#841).
*/
function runCli(cwd: string, timeoutMs = 8000): Promise<CliResult> {
function runCli(cwd: string, timeoutMs = 20_000): Promise<CliResult> {
return new Promise<CliResult>((resolve, reject) => {
const startedAt = Date.now();
const child: ChildProcess = spawn(process.execPath, [tsxCli, cliEntry], {
cwd,
env: { ...process.env, NO_COLOR: '1', FORCE_COLOR: '0' },
Expand All @@ -52,6 +55,14 @@ function runCli(cwd: string, timeoutMs = 8000): Promise<CliResult> {
}, timeoutMs);
child.on('exit', (code, signal) => {
clearTimeout(timer);
// Logged unconditionally (not just on near-timeout runs) so CI
// history builds a real latency distribution for this spawn+tsx
// path. Without it, a future timeout (#841) only tells us "> N
// ms", never how much margin was actually needed.
// eslint-disable-next-line no-console
console.info(
`[server.spec] runCli(${cwd}) exited in ${Date.now() - startedAt}ms (code=${code}, signal=${signal})`,
);
resolve({ code, signal, stdout, stderr });
});
child.on('error', (error) => {
Expand Down Expand Up @@ -112,7 +123,7 @@ describe('runServerCommand boot (virtualTree)', () => {
// stack frames) must not be the source of the output.
expect(result.stderr).not.toContain('PathConflictError:');
expect(result.stderr).not.toMatch(/^\s+at\s/m);
}, 15_000);
}, 25_000);

test('exits 1 with file name when a frontmatter pathKey is missing (regression: #754)', async () => {
await fs.writeFile(
Expand All @@ -136,5 +147,5 @@ describe('runServerCommand boot (virtualTree)', () => {
expect(result.code).toBe(1);
expect(result.stderr).toContain('Failed to load virtualTree resolver state');
expect(result.stderr).toContain('7.html');
}, 15_000);
}, 25_000);
});
Loading