Skip to content

Ukol 3 - Milan Staněk#32

Open
mistacms wants to merge 1 commit intoczcodecamp:masterfrom
mistacms:ukol_3
Open

Ukol 3 - Milan Staněk#32
mistacms wants to merge 1 commit intoczcodecamp:masterfrom
mistacms:ukol_3

Conversation

@mistacms
Copy link
Copy Markdown

implementacia zmeny mena, prijmeni, telefonu, hesla a jednej korespondencnej adresy

Copy link
Copy Markdown
Member

@klatys klatys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pozor na přepisování indentu, přijde mi, že jsi nevycházel z aktuálního masteru v originu (duplikuješ změny, které tam již jsou)


public function __construct(
UserFacade $userFacade,
UserFacade $userFacade,
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tady bacha na indenty (i :40)


$form->handleRequest($request);

if ($form->isSubmitted()) {
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

&& isValid


if ($form->isSubmitted()) {

$this->entityManager->persist($user);
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do facade/repository s tím :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants