feat: extend and improve caching support #123
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iguration parameters
elichad
reviewed
Nov 27, 2025
Comment on lines
+206
to
+212
| @click.option( | ||
| '--cache-max-age', | ||
| type=click.INT, | ||
| default=constants.DEFAULT_HTTP_CACHE_MAX_AGE, | ||
| show_default=True, | ||
| help="Maximum age of the HTTP cache in seconds", | ||
| ) |
Contributor
There was a problem hiding this comment.
Is there a way to set this so that the cache never expires? Set to -1?
(I see that -1 in the code but it should be documented if it's allowed here)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request extends the existing HTTP caching functionality in the RO-Crate validator.
Previously, caching was available only at the session level and was transient. Now, a persistent cache can be enabled by specifying a
cache pathandmaximum age. The session cache remains active by default for repeated requests within a session, while the persistent cache allows caching across multiple sessions.The cache stored at a specific path (as specified by
cache-path) can be migrated between different systems, potentially supporting the scenario described in #115.Cache parameters can be configured via new CLI options
--cache-max-age,--cache-path, or programmatically through the corresponding internal settings.The
--no-cacheoption allows ignoring any existing cache, forcing requests to bypass cached data.[addresses #114 and #115]