feat: mark exportMode and fileIds as deprecated in add_distribution()#244
Merged
andrii-bodnar merged 2 commits intomainfrom Mar 3, 2026
Merged
feat: mark exportMode and fileIds as deprecated in add_distribution()#244andrii-bodnar merged 2 commits intomainfrom
exportMode and fileIds as deprecated in add_distribution()#244andrii-bodnar merged 2 commits intomainfrom
Conversation
…ution Co-authored-by: andrii-bodnar <[email protected]>
Copilot
AI
changed the title
[WIP] Mark deprecated exportMode and fileIds in Add Distribution
feat: mark Mar 3, 2026
exportMode and fileIds as deprecated in add_distribution()
andrii-bodnar
approved these changes
Mar 3, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #244 +/- ##
==========================================
+ Coverage 99.39% 99.39% +0.01%
==========================================
Files 182 182
Lines 8460 8472 +12
Branches 187 189 +2
==========================================
+ Hits 8408 8420 +12
Misses 36 36
Partials 16 16 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Crowdin API has deprecated
exportModeandfileIdsparameters on the Add Distribution endpoint. This updates the Python client to surface those deprecations viaDeprecationWarningwhile preserving full backward compatibility.Changes
resource.py: EmitDeprecationWarningwhenexportModeorfileIdsare passed toadd_distribution(); changeexportModedefault fromExportMode.DEFAULT→Noneso it is omitted from the request body when not explicitly settests/: Wrap existing test cases using deprecated params withpytest.warns(DeprecationWarning); update expectedrequest_datato reflect newexportModedefault; add a test covering the no-deprecated-params pathExample
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.