Repository navigation
fix: honor RUST_LOG in logging and fix the fatal doc - #38
Merged
Merged
Conversation
configure(debug) set one max level for every crate in the binary, so --debug raised h2, hyper, tonic and the rest of the transport stack to DEBUG and buried the function's own logs, and RUST_LOG was ignored. Build an EnvFilter instead. Under --debug everything is at DEBUG except the gRPC, HTTP/2 and TLS crates, which stay at INFO; RUST_LOG, when set, replaces the level selection in full. A new logging::Builder keeps configure's defaults and adds quiet(targets) to hold back more crates. Logs now go to stderr instead of stdout, like function-sdk-go's zap loggers. Fixes #32 Signed-off-by: Jonasz Małecki <jonasz@upbound.io>
Crossplane stops the pipeline at the first fatal result: later steps do not run, and nothing is applied or garbage-collected for that reconcile. Fixes #37 Signed-off-by: Jonasz Małecki <jonasz@upbound.io>
jonasz-lasut
marked this pull request as ready for review
October 11, 2026 15:38
This was referenced Oct 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the
logging::Builderproposed in #32 (anEnvFilterthat honorsRUST_LOG, holds the gRPC transport crates at INFO under--debugand writes to stderr) and the correctedresponse::fataldoc comment from #37.Fixes #32
Fixes #37