Repository navigation
Conversation
Previously, render tried to start all runtime xpkg dependencies as functions, including providers. This didn't cause any problems (the providers sat running, doing nothing), but was wasteful and increased the chance of render timing out while pulling packages. Explicitly check the kind of each dependency and skip any that are not functions. Signed-off-by: Adam Wolfe Gordon <awg@upbound.io>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthrough
ChangesFunction dependency filtering
Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~5 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to Provider dependencies remain in Configuration metadata, and only function dependencies are started. No merge-blocking risk is evident from this change. Pre-merge checks |
|
Description of your changes
Previously, render tried to start all runtime xpkg dependencies as functions, including providers. This didn't cause any problems (the providers sat running, doing nothing), but was wasteful and increased the chance of render timing out while pulling packages.
Explicitly check the kind of each dependency and skip any that are not functions.
I have:
./nix.sh flake checkto ensure this PR is ready for review.- [ ] Added or updated unit tests.- [ ] Linked a PR or a docs tracking issue to document this change.backport release-x.ylabels to auto-backport this PR.