fix(tools): use LF line endings in generate_tool_specs.py on Windows#4888
Open
NIK-TIGER-BILL wants to merge 1 commit intocrewAIInc:mainfrom
Open
fix(tools): use LF line endings in generate_tool_specs.py on Windows#4888NIK-TIGER-BILL wants to merge 1 commit intocrewAIInc:mainfrom
NIK-TIGER-BILL wants to merge 1 commit intocrewAIInc:mainfrom
Conversation
On Windows, Python's text mode uses CRLF line endings by default. This causes generate_tool_specs.py to regenerate tool.specs.json with CRLF, making every line appear as modified in git diff. Pass newline='\n' to open() to force LF line endings regardless of OS. Fixes crewAIInc#4737
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On Windows, Python's
open()in text mode uses CRLF (\r\n) line endings by default. Runninggenerate_tool_specs.pyon Windows regeneratestool.specs.jsonwith CRLF, causing every line to appear modified ingit diffeven though content is unchanged.Fix
Pass
newline="\n"toopen()insave_to_json()to force LF line endings regardless of the operating system:Fixes #4737
Note
Low Risk
Low risk: a single file-write option change that only affects newline normalization in generated JSON output.
Overview
Ensures
ToolSpecExtractor.save_to_json()opens the output file withnewline="\n", so regeneratingtool.specs.jsonon Windows uses LF instead of CRLF and avoids whole-file diff churn.Written by Cursor Bugbot for commit 8e936f9. This will update automatically on new commits. Configure here.