fix: replace raw echo with standard output helpers in db/create-deploy-script#704
Merged
dnyw4l3n13 merged 1 commit intoJun 23, 2026
Conversation
Collaborator
|
All CI checks pass (build-pre-release and pull-request both green). Auto-merge has been enabled — the PR will merge automatically once any required conditions are met. |
dnyw4l3n13
reviewed
Jun 23, 2026
…y-script Replace the bare-echo die() implementation and add the full set of standard output helpers (die, success, info) as defined in shell-scripts.instructions.md. die() now writes to stderr with colour support, matching the project convention. Closes #620 Prompt: Work on issue #620 in credfeto/scripts.
dnyw4l3n13
force-pushed
the
fix/620-replace-echo-with-output-helpers-in-create-deploy-script
branch
from
11019e5 to
20e9746
Compare
Owner
Super-linter summary
All files and directories linted successfully For more information, see the GitHub Actions workflow run Powered by Super-linter |
credfeto
approved these changes
Jun 23, 2026
dnyw4l3n13
deleted the
fix/620-replace-echo-with-output-helpers-in-create-deploy-script
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
die()implementation indb/create-deploy-scriptwith the standard implementation from the project's shell-script rulesdie,success,info) as defined inshell-scripts.instructions.mddie()now writes to stderr with colour support when attached to a terminal, matching the project conventionCloses #620
Test plan
shellcheck db/create-deploy-scriptpassesdiewrites to stderr with colour code when terminal is attached, plain when piped