Skip to content

fix: replace raw echo with output helpers in db/dbappsettings#700

Merged
dnyw4l3n13 merged 1 commit into
mainfrom
fix/622-replace-echo-dbappsettings
Jun 22, 2026
Merged

fix: replace raw echo with output helpers in db/dbappsettings#700
dnyw4l3n13 merged 1 commit into
mainfrom
fix/622-replace-echo-dbappsettings

Conversation

@dnyw4l3n13

Copy link
Copy Markdown
Collaborator

Summary

  • Removed the non-standard die() implementation and duplicate BASEDIR assignment
  • Sourced dbenv first so the standard die, info, and success helpers are available
  • Replaced all echo calls with info for progress output
  • Fixed useless cat (SC2002) by passing the file directly to jq

Closes #622

@dnyw4l3n13 dnyw4l3n13 self-assigned this Jun 21, 2026
@dnyw4l3n13 dnyw4l3n13 added AI-Work Work for an AI Agent Urgent Urgent Priority labels Jun 21, 2026
@dnyw4l3n13 dnyw4l3n13 marked this pull request as ready for review June 21, 2026 12:52
@dnyw4l3n13

Copy link
Copy Markdown
Collaborator Author

All work is complete for this PR. Summary of changes in db/dbappsettings:

  • Removed duplicate BASEDIR assignment
  • Removed non-standard local die() implementation
  • Sourced dbenv before first output so standard die, info, and success helpers are available
  • Replaced all raw echo calls with info
  • Fixed useless cat (SC2002) by passing the file directly to jq
  • Added changelog entry under Fixed

CI checks are all passing. PR is ready for review.

@credfeto

Copy link
Copy Markdown
Owner

Super-linter summary

Language Validation result
BASH Pass ✅

All files and directories linted successfully

For more information, see the GitHub Actions workflow run

Powered by Super-linter

@dnyw4l3n13 dnyw4l3n13 enabled auto-merge June 21, 2026 13:31
@dnyw4l3n13

Copy link
Copy Markdown
Collaborator Author

All work is complete. CI checks are all passing and auto-merge has been enabled — the PR will merge automatically once any remaining required checks complete.

@dnyw4l3n13 dnyw4l3n13 force-pushed the fix/622-replace-echo-dbappsettings branch from 6f93197 to 9668c2a Compare June 22, 2026 02:21
@dnyw4l3n13

Copy link
Copy Markdown
Collaborator Author

Rebased the branch onto current main (super-linter bump from #701 was blocking auto-merge). Force-pushed with --force-with-lease. CI checks are now running — auto-merge will complete once they pass.

@credfeto

credfeto commented Jun 22, 2026

Copy link
Copy Markdown
Owner

Super-linter summary

Language Validation result
BASH Pass ✅

All files and directories linted successfully

For more information, see the GitHub Actions workflow run

Powered by Super-linter

@dnyw4l3n13 dnyw4l3n13 force-pushed the fix/622-replace-echo-dbappsettings branch from 9668c2a to ec3bf4a Compare June 22, 2026 02:35
@dnyw4l3n13

Copy link
Copy Markdown
Collaborator Author

Rebased the branch onto current main (actions/checkout bump from #702 and GitHub Actions workflow updates landed on main). Force-pushed with --force-with-lease. CI checks are now running — auto-merge will complete once they pass.

Prompt: Replace raw echo with output helpers in db/dbappsettings
@dnyw4l3n13 dnyw4l3n13 force-pushed the fix/622-replace-echo-dbappsettings branch from ec3bf4a to 126c23b Compare June 22, 2026 02:37
@dnyw4l3n13

Copy link
Copy Markdown
Collaborator Author

CI checks are currently running after the latest rebase (actions/checkout bump and GitHub Actions workflow updates from main). Auto-merge is already enabled — the PR will merge automatically once all required checks pass.

Current status: all checks pending.

@dnyw4l3n13

Copy link
Copy Markdown
Collaborator Author

CI checks are currently running. Auto-merge is already enabled — the PR will merge automatically once all required checks pass.

Current status: checks pending (has-no-file-or-folder-case-sensitivity-issues, dependency-review, change-log-entry-is-in-unreleased, build-pre-release, does-not-contain-secrets, include-changelog-entry, lint-code, no-ignored-files, no-merge-commits, requirements, valid-changelog, Copilot Code Review).

@dnyw4l3n13

Copy link
Copy Markdown
Collaborator Author

CI checks are still running. Auto-merge is already enabled — the PR will merge automatically once all required checks pass.

Current status: build-pre-release, change-log-entry-is-in-unreleased, does-not-contain-secrets, has-no-file-or-folder-case-sensitivity-issues, no-ignored-files, dependency-review, valid-changelog, lint-code, and include-changelog-entry are all pending. Super-linter (BASH) has already passed. No outstanding work remains on the branch.

@dnyw4l3n13

Copy link
Copy Markdown
Collaborator Author

All CI checks are passing and auto-merge is already enabled. The PR will merge automatically once GitHub processes it. No outstanding work remains.

@dnyw4l3n13 dnyw4l3n13 merged commit 7340d3c into main Jun 22, 2026
25 checks passed
@dnyw4l3n13 dnyw4l3n13 deleted the fix/622-replace-echo-dbappsettings branch June 22, 2026 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AI-Work Work for an AI Agent Urgent Urgent Priority

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace raw echo with output helpers in db/dbappsettings

2 participants