fix: replace raw echo with output helpers in development/buildnugetconfig

[dnyw4l3n13]

Summary

• Replace the die() stub (bare echo) with the standard implementation using printf and ANSI colour codes
• Add the missing success() and info() helpers
• Replace the user-facing echo "NuGet.Config: ..." line with info
• Add a success "Completed" at the end of the script

Why

Consistent output helpers across all scripts improve readability, error reporting, and rule compliance.

Closes #630

Test plan

• Script passes shellcheck
• die outputs to stderr with red ✗
• info outputs the NuGet.Config path line
• success is called at script completion

[dnyw4l3n13]

Status Update

Implementation complete. Changes made to development/buildnugetconfig:

• Replaced the die() stub (bare echo to stdout) with the standard implementation using printf with ANSI colour codes directed to stderr
• Added missing success() and info() helpers
• Replaced echo "NuGet.Config: $NUGET_CONF_FILE" with info "NuGet.Config: $NUGET_CONF_FILE"
• Added success "Completed" at the end of the script
• Cleaned up trailing whitespace

All pre-commit hooks including shellcheck pass on the changed file.

[credfeto]

Super-linter summary

Language	Validation result
BASH	Fail ❌
JSON	Pass ✅

Super-linter detected linting errors

For more information, see the GitHub Actions workflow run

Powered by Super-linter

BASH

�[1mIn /github/workspace/db/updatedb-redgate line 3:�[0m
�[0mdie() {�[0m
�[32m^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).�[0m


�[1mIn /github/workspace/db/createmssqldb line 3:�[0m
�[0mdie() {�[0m
�[32m^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).�[0m


�[1mIn /github/workspace/db/dropmssqldb line 3:�[0m
�[0mdie() {�[0m
�[32m^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).�[0m


�[1mIn /github/workspace/db/extractdb line 3:�[0m
�[0mdie() {�[0m
�[32m^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).�[0m

For more information:
  https://www.shellcheck.net/wiki/SC2329 -- This function is never invoked. C...

[dnyw4l3n13]

Fixed in fef2d7c — removed shadowed die() definitions from the four db/ scripts and updated db/dbenv with standard die/success/info helpers to resolve the SC2329 BASH linting failures.

Root cause: Each script defined die() locally, but immediately sourced dbenv which also defines die(), overriding the local version. All subsequent die() calls used dbenv's definition, making the local one unreachable. Shellcheck (SC2329) correctly flagged this.

Changes:

• db/dbenv: replaced bare-echo die() with standard printf/ANSI implementation; added success() and info() helpers; replaced all echo output calls with info; fixed parse_cmdline $@ → "$@" (SC2068); fixed unquoted mkdir $REDGATE; removed unused SCHEMA= (SC2034)
• db/createmssqldb, db/dropmssqldb, db/extractdb, db/updatedb-redgate: removed redundant die() definition; moved script-dir info line to after sourcing so info() is available; replaced remaining bare echo calls with info

[credfeto]

Super-linter summary

Language	Validation result
BASH	Pass ✅
JSON	Pass ✅

All files and directories linted successfully

For more information, see the GitHub Actions workflow run

Powered by Super-linter

[dnyw4l3n13]

Status Update

All work is complete. Summary of changes made in this PR:

development/buildnugetconfig (commits a0f027c1, 7dbabff3):

• Replaced the bare-echo die() stub with the standard printf/ANSI colour code implementation directed to stderr
• Added missing success() and info() helpers
• Replaced echo "NuGet.Config: $NUGET_CONF_FILE" with info "NuGet.Config: $NUGET_CONF_FILE"
• Added success "Completed" at the end of the script

db/dbenv, db/createmssqldb, db/dropmssqldb, db/extractdb, db/updatedb-redgate (commit fef2d7c2):

• Removed shadowed die() definitions from the four db/ scripts (SC2329 fix)
• Updated db/dbenv with standard die/success/info helpers
• Replaced remaining bare echo calls with info
• Fixed parse_cmdline $@ → "$@" (SC2068)
• Fixed unquoted mkdir $REDGATE

All CI checks pass including super-linter (BASH ✅, JSON ✅).