Skip to content

fix: replace raw echo with output helpers in general/install-latest-dotnet#684

Merged
credfeto merged 1 commit into
mainfrom
fix/636-replace-raw-echo-install-latest-dotnet
Jun 16, 2026
Merged

fix: replace raw echo with output helpers in general/install-latest-dotnet#684
credfeto merged 1 commit into
mainfrom
fix/636-replace-raw-echo-install-latest-dotnet

Conversation

@github-actions

@github-actions github-actions Bot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Replace the non-standard die() implementation with the project-standard die, success, and info output helpers in general/install-latest-dotnet
  • Update say() to use info instead of raw echo
  • Update say_err() to delegate to die instead of duplicating the exit logic
  • Replace all user-facing echo calls in the main body with info or success as appropriate
  • Remove the redundant second #!/bin/bash shebang line
  • Passes shellcheck with no warnings

Closes #636

@github-actions github-actions Bot added the auto-pr Pull request created automatically label Jun 15, 2026
@dnyw4l3n13 dnyw4l3n13 added AI-Work Work for an AI Agent Urgent Urgent Priority labels Jun 15, 2026
@credfeto

Copy link
Copy Markdown
Owner

Super-linter summary

Language Validation result
BASH Pass ✅

All files and directories linted successfully

For more information, see the GitHub Actions workflow run

Powered by Super-linter

@dnyw4l3n13

Copy link
Copy Markdown
Collaborator

All CI checks are passing and BASH linting is clean. No outstanding reviews or comments to address. PR is ready for review and merge.

@credfeto credfeto enabled auto-merge June 15, 2026 17:05
@credfeto

Copy link
Copy Markdown
Owner

Super-linter summary

Language Validation result
BASH Pass ✅

All files and directories linted successfully

For more information, see the GitHub Actions workflow run

Powered by Super-linter

@dnyw4l3n13

Copy link
Copy Markdown
Collaborator

All CI checks are passing, BASH linting is clean, and the PR has been approved by @credfeto. No outstanding work remains — PR is ready for merge.

…otnet

Replace raw echo calls with die/info/success output helpers in
general/install-latest-dotnet, consistent with shell-script conventions.

Prompt: Work on issue #636 in credfeto/scripts.
@dnyw4l3n13 dnyw4l3n13 force-pushed the fix/636-replace-raw-echo-install-latest-dotnet branch from 415a17f to f89a255 Compare June 16, 2026 08:41
@credfeto

Copy link
Copy Markdown
Owner

Super-linter summary

Language Validation result
BASH Pass ✅

All files and directories linted successfully

For more information, see the GitHub Actions workflow run

Powered by Super-linter

@credfeto credfeto merged commit faab7fc into main Jun 16, 2026
28 checks passed
@credfeto credfeto deleted the fix/636-replace-raw-echo-install-latest-dotnet branch June 16, 2026 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AI-Work Work for an AI Agent auto-pr Pull request created automatically Urgent Urgent Priority

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace raw echo with output helpers in general/install-latest-dotnet

2 participants