Skip to content

fix: replace raw echo with output helpers in general/update-dotnet-tools#678

Merged
credfeto merged 1 commit into
mainfrom
fix/639-replace-echo-with-output-helpers-update-dotnet-tools
Jun 14, 2026
Merged

fix: replace raw echo with output helpers in general/update-dotnet-tools#678
credfeto merged 1 commit into
mainfrom
fix/639-replace-echo-with-output-helpers-update-dotnet-tools

Conversation

@github-actions

@github-actions github-actions Bot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add die, success, and info output helpers to general/update-dotnet-tools
  • Replace raw echo "Updating $package..." with info "Updating $package..."
  • Also fix missing newline at end of file and trailing whitespace in do line

Closes #639

Test plan

  • Script passes shellcheck (verified via pre-commit hooks)
  • Behaviour is preserved — progress is reported via info helper instead of bare echo

@github-actions github-actions Bot added the auto-pr Pull request created automatically label Jun 12, 2026
@dnyw4l3n13 dnyw4l3n13 added AI-Work Work for an AI Agent Urgent Urgent Priority labels Jun 12, 2026
@dnyw4l3n13

Copy link
Copy Markdown
Collaborator

All work is complete for this PR.

Status summary:

  • CI checks: both build-pre-release and pull-request are passing
  • Output helpers (die, success, info) added to general/update-dotnet-tools matching the canonical implementations
  • Raw echo "Updating $package..." replaced with info "Updating $package..."
  • Trailing whitespace on do line fixed
  • Missing newline at end of file added
  • Changelog entry added under Fixed

All acceptance criteria from issue #639 are satisfied. Ready for review.

@dnyw4l3n13

Copy link
Copy Markdown
Collaborator

PR is verified complete and ready for review.

CI status: Both build-pre-release and pull-request checks are passing.

Changes verified:

  • Output helpers (die, success, info) added to general/update-dotnet-tools, matching the canonical implementations in shell-scripts.examples.md
  • Raw echo "Updating $package..." replaced with info "Updating $package..."
  • Trailing whitespace on do line removed
  • Missing newline at end of file added
  • Changelog entry added under Fixed

No outstanding review comments or CI failures. All acceptance criteria from issue #639 are satisfied.

@dnyw4l3n13 dnyw4l3n13 force-pushed the fix/639-replace-echo-with-output-helpers-update-dotnet-tools branch from 05df9f7 to 5593499 Compare June 12, 2026 17:56
@credfeto

Copy link
Copy Markdown
Owner

Super-linter summary

Language Validation result
BASH Pass ✅

All files and directories linted successfully

For more information, see the GitHub Actions workflow run

Powered by Super-linter

@dnyw4l3n13

Copy link
Copy Markdown
Collaborator

PR #678 is complete and all CI checks are passing.

Changes verified:

  • Output helpers (die, success, info) added to general/update-dotnet-tools
  • Raw echo "Updating $package..." replaced with info "Updating $package..."
  • Trailing whitespace on do line removed
  • Missing newline at end of file added
  • Changelog entry added under Fixed

All acceptance criteria from issue #639 are satisfied. Ready for merge.

@dnyw4l3n13

Copy link
Copy Markdown
Collaborator

All work is complete. CI checks are all passing:

  • Output helpers (die, success, info) added to general/update-dotnet-tools, matching the canonical implementations
  • Raw echo "Updating $package..." replaced with info "Updating $package..."
  • Trailing whitespace on do line removed
  • Missing newline at end of file added
  • Changelog entry added under Fixed

PR is ready for merge.

@dnyw4l3n13 dnyw4l3n13 force-pushed the fix/639-replace-echo-with-output-helpers-update-dotnet-tools branch from 5593499 to 800abcd Compare June 12, 2026 19:09
@dnyw4l3n13

Copy link
Copy Markdown
Collaborator

CI check lint-code is still pending. Stopping and waiting for it to complete before proceeding.

@credfeto

Copy link
Copy Markdown
Owner

Super-linter summary

Language Validation result
BASH Pass ✅

All files and directories linted successfully

For more information, see the GitHub Actions workflow run

Powered by Super-linter

@dnyw4l3n13

Copy link
Copy Markdown
Collaborator

All work is complete and verified for this PR.

CI status: All required checks are passing (build-pre-release, pull-request, lint-code, valid-changelog, etc.).

Changes verified:

  • Output helpers (die, success, info) added to general/update-dotnet-tools, matching the canonical implementations in shell-scripts.examples.md exactly
  • Raw echo "Updating $package..." replaced with info "Updating $package..."
  • Trailing whitespace on do line removed
  • Missing newline at end of file added
  • Changelog entry added under Fixed

No outstanding review comments or CI failures. All acceptance criteria from issue #639 are satisfied. Ready for merge.

@dnyw4l3n13 dnyw4l3n13 force-pushed the fix/639-replace-echo-with-output-helpers-update-dotnet-tools branch from 800abcd to aae2746 Compare June 13, 2026 04:56
@credfeto

Copy link
Copy Markdown
Owner

Super-linter summary

Language Validation result
BASH Pass ✅

All files and directories linted successfully

For more information, see the GitHub Actions workflow run

Powered by Super-linter

@dnyw4l3n13

Copy link
Copy Markdown
Collaborator

PR #678 reviewed and verified complete.

Status: All CI checks passing, no outstanding review comments.

Changes verified correct:

  • Output helpers (die, success, info) added to general/update-dotnet-tools, matching the canonical implementations in shell-scripts.examples.md exactly
  • Raw echo "Updating $package..." replaced with info "Updating $package..."
  • Trailing whitespace on do line removed
  • Missing newline at end of file added
  • Changelog entry added under Fixed

Ready for merge.

@dnyw4l3n13

Copy link
Copy Markdown
Collaborator

PR #678 has been reviewed and is ready for merge.

Status: All CI checks are passing and no outstanding work remains.

Changes in this PR:

  • Output helpers (die, success, info) added to general/update-dotnet-tools, matching the canonical implementations in shell-scripts.examples.md
  • Raw echo "Updating $package..." replaced with info "Updating $package..."
  • Trailing whitespace on do line removed
  • Missing newline at end of file added
  • Changelog entry added under Fixed

All acceptance criteria from issue #639 are satisfied. The PR is not in draft and all required CI checks have passed.

Prompt: Replace raw echo with output helpers in `general/update-dotnet-tools`

Closes #639
@dnyw4l3n13 dnyw4l3n13 force-pushed the fix/639-replace-echo-with-output-helpers-update-dotnet-tools branch from aae2746 to 6c8317f Compare June 13, 2026 12:02
@credfeto

Copy link
Copy Markdown
Owner

Super-linter summary

Language Validation result
BASH Pass ✅

All files and directories linted successfully

For more information, see the GitHub Actions workflow run

Powered by Super-linter

@dnyw4l3n13

Copy link
Copy Markdown
Collaborator

PR #678 reviewed and confirmed complete.

CI status: All required checks are passing.

Summary of changes already in this PR:

  • Output helpers (die, success, info) added to general/update-dotnet-tools, matching the canonical implementations
  • Raw echo "Updating $package..." replaced with info "Updating $package..."
  • Trailing whitespace on do line removed
  • Missing newline at end of file added
  • Changelog entry added under Fixed

No outstanding review comments or CI failures. All acceptance criteria from issue #639 are satisfied. Ready for merge.

@credfeto credfeto enabled auto-merge June 14, 2026 12:25
@credfeto credfeto merged commit b98246f into main Jun 14, 2026
28 checks passed
@credfeto credfeto deleted the fix/639-replace-echo-with-output-helpers-update-dotnet-tools branch June 14, 2026 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AI-Work Work for an AI Agent auto-pr Pull request created automatically Urgent Urgent Priority

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace raw echo with output helpers in general/update-dotnet-tools

2 participants