Skip to content

fix: replace raw echo with output helpers in general/wallpaper#676

Merged
credfeto merged 2 commits into
mainfrom
fix/640-replace-echo-in-general-wallpaper
Jun 12, 2026
Merged

fix: replace raw echo with output helpers in general/wallpaper#676
credfeto merged 2 commits into
mainfrom
fix/640-replace-echo-in-general-wallpaper

Conversation

@github-actions

@github-actions github-actions Bot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Replaced the non-standard die() implementation with the canonical die/success/info output helpers
  • Replaced all bare echo calls with the appropriate helper: info for progress announcements, success for completion messages
  • Script behaviour is preserved; only output formatting has changed

Closes #640

Test plan

  • Script passes shellcheck (verified via pre-commit hook)
  • All bare echo calls removed and replaced with die/info/success
  • Script behaviour unchanged

Replaced all bare echo calls with die/info/success helpers as required
by the shell-script output conventions.

Prompt: Work on issue #640 in credfeto/scripts.

Closes #640
@github-actions github-actions Bot added the auto-pr Pull request created automatically label Jun 12, 2026
@dnyw4l3n13 dnyw4l3n13 marked this pull request as draft June 12, 2026 12:33
@dnyw4l3n13 dnyw4l3n13 changed the title chore: add changelog entry for general/wallpaper output helper migration fix: replace raw echo with output helpers in general/wallpaper Jun 12, 2026
@dnyw4l3n13 dnyw4l3n13 added AI-Work Work for an AI Agent Urgent Urgent Priority labels Jun 12, 2026
@dnyw4l3n13 dnyw4l3n13 marked this pull request as ready for review June 12, 2026 12:58
@dnyw4l3n13

Copy link
Copy Markdown
Collaborator

All CI checks are passing. The general/wallpaper script now uses the canonical die/success/info output helpers in place of all bare echo calls. Implementation matches the reference pattern from shell-scripts.examples.md exactly. PR is ready for review.

@credfeto

Copy link
Copy Markdown
Owner

Super-linter summary

Language Validation result
BASH Pass ✅

All files and directories linted successfully

For more information, see the GitHub Actions workflow run

Powered by Super-linter

@dnyw4l3n13

Copy link
Copy Markdown
Collaborator

All CI checks are passing and no review comments require action. PR is complete and ready for merge.

@credfeto credfeto merged commit 063eb85 into main Jun 12, 2026
59 checks passed
@credfeto credfeto deleted the fix/640-replace-echo-in-general-wallpaper branch June 12, 2026 14:35
@credfeto

Copy link
Copy Markdown
Owner

Super-linter summary

Language Validation result

All files and directories linted successfully

For more information, see the GitHub Actions workflow run

Powered by Super-linter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AI-Work Work for an AI Agent auto-pr Pull request created automatically Urgent Urgent Priority

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace raw echo with output helpers in general/wallpaper

2 participants