Skip to content

fix: replace raw echo with output helpers in git/clean-all#674

Merged
credfeto merged 2 commits into
mainfrom
fix/642-replace-echo-with-output-helpers-in-git-clean-all
Jun 12, 2026
Merged

fix: replace raw echo with output helpers in git/clean-all#674
credfeto merged 2 commits into
mainfrom
fix/642-replace-echo-with-output-helpers-in-git-clean-all

Conversation

@github-actions

@github-actions github-actions Bot commented Jun 12, 2026 •
edited by dnyw4l3n13
Loading

Copy link
Copy Markdown
Contributor

Summary

  • Added die, info, and success output helper functions to git/clean-all
  • Replaced all bare echo calls with the appropriate helpers
  • Script passes shellcheck and checkbashisms with no warnings

Closes #642

@dnyw4l3n13
fix: replace raw echo with output helpers in git/clean-all
e32ddd5 
Replaced all bare echo calls with die/info/success helpers as required
by the shell-script output conventions.

Prompt: Replace raw echo with output helpers in `git/clean-all` — issue #642

Closes #642
@dnyw4l3n13
chore: add changelog entry for git/clean-all output helper migration
e46af06
@github-actions github-actions Bot added the auto-pr Pull request created automatically label Jun 12, 2026
@dnyw4l3n13 dnyw4l3n13 added AI-Work Work for an AI Agent Urgent Urgent Priority labels Jun 12, 2026
@dnyw4l3n13 dnyw4l3n13 changed the title chore: add changelog entry for git/clean-all output helper migration fix: replace raw echo with output helpers in git/clean-all Jun 12, 2026
@dnyw4l3n13 dnyw4l3n13 marked this pull request as draft June 12, 2026 10:07
@dnyw4l3n13 dnyw4l3n13 mentioned this pull request Jun 12, 2026
Closed
@dnyw4l3n13

dnyw4l3n13 commented Jun 12, 2026

Copy link
Copy Markdown
Collaborator

CI checks are pending — waiting for results before proceeding.

Completed so far:

  • git/clean-all updated: bare echo replaced with die/info/success helpers
  • CHANGELOG.md entry added
  • Branch pushed, draft PR opened
  • shellcheck and checkbashisms pass locally

Will continue once CI completes.

@dnyw4l3n13

dnyw4l3n13 commented Jun 12, 2026

Copy link
Copy Markdown
Collaborator

CI checks are still pending — waiting before proceeding further.

Pending checks:

  • change-log-entry-is-in-unreleased
  • lint-code

All other checks have passed. Will continue once these complete.

@credfeto

credfeto commented Jun 12, 2026

Copy link
Copy Markdown
Owner

Super-linter summary

Language Validation result
BASH Pass ✅

All files and directories linted successfully

For more information, see the GitHub Actions workflow run

Powered by Super-linter

@dnyw4l3n13

dnyw4l3n13 commented Jun 12, 2026

Copy link
Copy Markdown
Collaborator

All CI checks pass and the implementation looks correct:

  • die, success, and info helper implementations match the reference in shell-scripts.examples.md exactly
  • All bare echo calls replaced with appropriate helpers (info for progress steps, success for completion)
  • shellcheck and checkbashisms pass (confirmed by lint-code CI check passing)
  • CHANGELOG.md entry added in the unreleased section

Marking PR as ready for review.

@dnyw4l3n13 dnyw4l3n13 marked this pull request as ready for review June 12, 2026 10:15
@credfeto

credfeto commented Jun 12, 2026

Copy link
Copy Markdown
Owner

Super-linter summary

Language Validation result
BASH Pass ✅

All files and directories linted successfully

For more information, see the GitHub Actions workflow run

Powered by Super-linter

@dnyw4l3n13

dnyw4l3n13 commented Jun 12, 2026

Copy link
Copy Markdown
Collaborator

PR #674 status review completed — all work is done.

Summary:

  • git/clean-all updated: die, info, and success helpers added; all bare echo calls replaced
  • CHANGELOG.md entry added in the unreleased section
  • All CI checks pass (linting, shellcheck, checkbashisms, changelog validation)
  • No outstanding review comments

PR is ready for merge.

@credfeto credfeto enabled auto-merge June 12, 2026 10:25
@credfeto credfeto merged commit b4c5c8a into main Jun 12, 2026
63 checks passed
@credfeto credfeto deleted the fix/642-replace-echo-with-output-helpers-in-git-clean-all branch June 12, 2026 10:26
@credfeto

credfeto commented Jun 12, 2026

Copy link
Copy Markdown
Owner

Super-linter summary

Language Validation result

All files and directories linted successfully

For more information, see the GitHub Actions workflow run

Powered by Super-linter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@credfeto credfeto credfeto approved these changes

Assignees

@github-actions github-actions[bot]

@dnyw4l3n13 dnyw4l3n13

Labels

AI-Work Work for an AI Agent auto-pr Pull request created automatically Urgent Urgent Priority

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Replace raw echo with output helpers in git/clean-all

2 participants

@dnyw4l3n13 @credfeto