-
Notifications
You must be signed in to change notification settings - Fork 0
chore: goreleaser #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -17,53 +17,28 @@ archives: | |||||||||||||||||
| ids: ["imap_targz"] | ||||||||||||||||||
| formats: ["tar.gz"] | ||||||||||||||||||
|
|
||||||||||||||||||
| dockers: | ||||||||||||||||||
| - image_templates: | ||||||||||||||||||
| - "creativeprojects/imap:latest-amd64" | ||||||||||||||||||
| - "creativeprojects/imap:{{ .RawVersion }}-amd64" | ||||||||||||||||||
| ids: | ||||||||||||||||||
| - imap_targz | ||||||||||||||||||
| use: buildx | ||||||||||||||||||
| goos: linux | ||||||||||||||||||
| goarch: amd64 | ||||||||||||||||||
| dockers_v2: | ||||||||||||||||||
| - images: | ||||||||||||||||||
| - "creativeprojects/imap" | ||||||||||||||||||
| - "ghcr.io/creativeprojects/imap" | ||||||||||||||||||
| dockerfile: build/Dockerfile | ||||||||||||||||||
| build_flag_templates: | ||||||||||||||||||
| - "--pull" | ||||||||||||||||||
| - "--label=org.opencontainers.image.created={{.Date}}" | ||||||||||||||||||
| - "--label=org.opencontainers.image.title={{.ProjectName}}" | ||||||||||||||||||
| - "--label=org.opencontainers.image.revision={{.FullCommit}}" | ||||||||||||||||||
| - "--label=org.opencontainers.image.version={{.Version}}" | ||||||||||||||||||
| - "--platform=linux/amd64" | ||||||||||||||||||
| - "--build-arg=ARCH=amd64" | ||||||||||||||||||
|
|
||||||||||||||||||
| - image_templates: | ||||||||||||||||||
| - "creativeprojects/imap:latest-arm64v8" | ||||||||||||||||||
| - "creativeprojects/imap:{{ .RawVersion }}-arm64v8" | ||||||||||||||||||
| ids: | ||||||||||||||||||
| - imap_targz | ||||||||||||||||||
| use: buildx | ||||||||||||||||||
| goos: linux | ||||||||||||||||||
| goarch: arm64 | ||||||||||||||||||
| dockerfile: build/Dockerfile | ||||||||||||||||||
| build_flag_templates: | ||||||||||||||||||
| - "--pull" | ||||||||||||||||||
| - "--label=org.opencontainers.image.created={{.Date}}" | ||||||||||||||||||
| - "--label=org.opencontainers.image.title={{.ProjectName}}" | ||||||||||||||||||
| - "--label=org.opencontainers.image.revision={{.FullCommit}}" | ||||||||||||||||||
| - "--label=org.opencontainers.image.version={{.Version}}" | ||||||||||||||||||
| - "--platform=linux/arm64/v8" | ||||||||||||||||||
| - "--build-arg=ARCH=arm64" | ||||||||||||||||||
|
|
||||||||||||||||||
| docker_manifests: | ||||||||||||||||||
| - name_template: creativeprojects/imap:{{ .RawVersion }} | ||||||||||||||||||
| image_templates: | ||||||||||||||||||
| - creativeprojects/imap:{{ .RawVersion }}-amd64 | ||||||||||||||||||
| - creativeprojects/imap:{{ .RawVersion }}-arm64v8 | ||||||||||||||||||
|
|
||||||||||||||||||
| - name_template: creativeprojects/imap:latest | ||||||||||||||||||
| image_templates: | ||||||||||||||||||
| - creativeprojects/imap:latest-amd64 | ||||||||||||||||||
| - creativeprojects/imap:latest-arm64v8 | ||||||||||||||||||
| tags: | ||||||||||||||||||
| - "{{ .RawVersion }}" | ||||||||||||||||||
| - "{{ if .IsNightly }}nightly{{ end }}" | ||||||||||||||||||
| - "{{ if not .IsNightly }}latest{{ end }}" | ||||||||||||||||||
| labels: | ||||||||||||||||||
| "org.opencontainers.image.description": "IMAP tools: backup, copy, move your emails between servers and locally" | ||||||||||||||||||
|
Comment on lines
+29
to
+32
|
||||||||||||||||||
| - "{{ if .IsNightly }}nightly{{ end }}" | |
| - "{{ if not .IsNightly }}latest{{ end }}" | |
| labels: | |
| "org.opencontainers.image.description": "IMAP tools: backup, copy, move your emails between servers and locally" | |
| - "{{ if .IsNightly }}nightly{{ else }}latest{{ end }}" | |
| labels: | |
| "org.opencontainers.image.description": "IMAP tools: backup, copy, move your emails between servers and locally" | |
| "org.opencontainers.image.description": "IMAP tools: backup, copy, move your emails between servers and locally" |
Copilot
AI
Feb 15, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR description mentions using new dockers-v2 from goreleaser, but only .goreleaser-docker-only.yml was migrated to use dockers_v2. The main .goreleaser.yml file (lines 64-108) still uses the old dockers format with docker_manifests. For consistency and to fully adopt goreleaser v2's dockers-v2 feature, consider updating the main configuration file as well, or document why this config uses the old format while the docker-only config uses the new format.
| Original file line number | Diff line number | Diff line change | ||
|---|---|---|---|---|
|
|
@@ -3,8 +3,9 @@ FROM alpine:latest | |||
| LABEL maintainer Fred <[email protected]> | ||||
|
|
||||
| ARG ARCH=amd64 | ||||
|
||||
| ARG ARCH=amd64 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The configuration now includes pushing to GitHub Container Registry (ghcr.io/creativeprojects/imap), but neither .github/workflows/docker.yml nor .github/workflows/release.yml include a login step for ghcr.io. You need to add authentication for ghcr.io using docker/login-action, typically with the GITHUB_TOKEN that's already available in the workflow. Without this, the Docker push to ghcr.io will fail.