Skip to content

#14719 FP uninitdata for new array with initializer #8528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chrchr-github wants to merge 3 commits into
base: main
Choose a base branch
from
+29 −5
Open

#14719 FP uninitdata for new array with initializer #8528

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b8fab85
#14719 FP uninitdata for new array with initializer
web-flow May 4, 2026
c501ff3
Fix
web-flow May 4, 2026
131c220
Fix
web-flow May 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions lib/checkuninitvar.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -784,12 +784,16 @@ bool CheckUninitVar::checkScopeForVariable(const Token *tok, const Variable& var
// standard or enum type: check if new initializes the allocated memory
if (var.typeStartToken()->isStandardType() || var.typeStartToken()->isEnumType()) {
// scalar new with initialization
if (Token::Match(tok->next(), "= new %type% ("))
return true;

// array new
if (Token::Match(tok->next(), "= new %type% [") && Token::simpleMatch(tok->linkAt(4), "] ("))
return true;
if (Token::Match(tok->next(), "= new ::|%type%")) {
const Token* initTok = tok->tokAt(4);
while (Token::Match(initTok, "::|%type%"))
initTok = initTok->next();
if (Token::simpleMatch(initTok, "["))
initTok = initTok->link()->next();
if (Token::Match(initTok, "[({]"))
return true;
}
}

continue;
Expand Down
20 changes: 20 additions & 0 deletions test/testuninitvar.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2181,6 +2181,26 @@ class TestUninitVar : public TestFixture {
" return s;\n"
"}\n");
ASSERT_EQUALS("", errout_str());

checkUninitVar("int f() {\n" // #14719
" int* p = new int[]{ 1, 2 };\n"
" int i = p[0] + p[1];\n"
" delete[] p;\n"
" return i;\n"
"}\n"
"int g() {\n"
" int* p = new std::int32_t[]{ 1, 2 };\n"
" int i = p[0] + p[1];\n"
" delete[] p;\n"
" return i;\n"
"}\n"
"int h() {\n"
" int* p = new ::std::int32_t[]{ 1, 2 };\n"
" int i = p[0] + p[1];\n"
" delete[] p;\n"
" return i;\n"
"}\n");
ASSERT_EQUALS("", errout_str());
}

// class / struct..
Expand Down
Loading